Skip to content

fix: Parse items from request body when not in kwargs #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sammish merged 1 commit into from
Dec 17, 2025
Merged

fix: Parse items from request body when not in kwargs #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion frappe_dotnet/api/sales_invoice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,22 @@ def _parse_request_data(kwargs):
"""Parse and normalize request data"""
data = frappe._dict(kwargs)

# If items not in kwargs, try to get from request JSON body
# Frappe doesn't always pass nested arrays through kwargs
if not data.get("items") and frappe.request and frappe.request.data:
try:
request_json = json.loads(frappe.request.data)
if isinstance(request_json, dict):
# Merge request JSON with kwargs (kwargs takes precedence for non-items)
for key, value in request_json.items():
if key not in data or data[key] is None:
data[key] = value
except (json.JSONDecodeError, AttributeError):
pass

# Debug log to help troubleshoot data format issues
frappe.log_error(
message=f"Received kwargs: {type(kwargs)}\nItems type: {type(kwargs.get('items'))}\nItems value: {kwargs.get('items')}",
message=f"Received kwargs: {type(kwargs)}\nItems type: {type(data.get('items'))}\nItems value: {data.get('items')}",
title="Sales Invoice API - Request Data Debug"
)

Expand Down
Loading