feat: Add authenticating step to ExecuteDrawer with enhanced UI#72
Open
Kenlachy wants to merge 2 commits intoezedike-evan:mainfrom
Open
feat: Add authenticating step to ExecuteDrawer with enhanced UI#72Kenlachy wants to merge 2 commits intoezedike-evan:mainfrom
Kenlachy wants to merge 2 commits intoezedike-evan:mainfrom
Conversation
- Add ExecuteDrawerStep type to types/index.ts
- Enhance authenticating step UI with spinner, anchor logo, and specific copy
- Show 'Proving wallet ownership to {anchorName}...' during SEP-10 auth
- Improve user understanding of Freighter authentication prompts
Addresses ezedike-evan#25
|
Someone is attempting to deploy a commit to the ezedikeevan's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Kenlachy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
- Update all workflow files to use Node.js 20.x and 22.x - Add engines field to package.json specifying >=20.19.0 - Fix husky prepare script to handle installation properly - Resolve CI check failures across all workflows Fixes failing CI checks in pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #25
Summary
Linked issue
Closes #
Changes
Testing notes
Automated
npm run typecheck· ⏳ not run / ✅ green / ❌ failingnpm run lint· ⏳ not run / ✅ green / ❌ failingnpm run test· ⏳ not run / ✅ green / ❌ failingnpm run build· ⏳ not run / ✅ green / ❌ failingNew / modified tests
Manual verification (if applicable)
Screenshots / recordings
Checklist
Correctness
npm run typecheckpassesnpm run lintpasses with zero new warnings (we run--max-warnings 0in CI)npm run testpasses; new behaviour has a testnpm run buildpassesData integrity
issue.md #005)isMock,// MOCK,// TODO: replace with real data, or commented-out real codestellar.tomlis publicly resolvable athttps://{domain}/.well-known/stellar.tomland containsTRANSFER_SERVER_SEP0024AbortControllertimeout is intact on anchor fetchescompleted | refunded | error) still stop the SWR loopSecurity & non-custody (see
docs/NON_CUSTODY.mdonce it lands).env.localis unchanged; new env vars are added to.env.exampleDocs
CHANGELOG.mdentry under[Unreleased]docs/*.mdupdated in the same PRdocs/ARCHITECTURE.mdupdated (file map, diagram, or invariants as applicable)docs/showcase/images/when relevant.env.example+ README env table updatedRelease hygiene
[ ]indocs/ROADMAP.mdis updatedBreaking changes
None.
For reviewers
Resolves #25