Open
Conversation
junha-ahn
requested changes
Oct 19, 2023
Comment on lines
+196
to
+207
| - name: id | ||
| in: query | ||
| required: true | ||
| required: false | ||
| schema: | ||
| $ref: '#/components/schemas/Pageable' | ||
| type: integer | ||
| format: int32 | ||
| - name: time | ||
| in: query | ||
| required: false | ||
| schema: | ||
| type: string | ||
| format: date-time |
Member
There was a problem hiding this comment.
키 이름을 last_access_id, last_access_time 등 으로 변경할 필요가 있어보입니다.
- 더 좋은 이름 있을 수 있으니 찾아보세요.
- 당근마켓, 인스타, 트위터, 페이스북 등 참고
- 무한스크롤 형태니까... Open API Docs 또는 개발자 도구 열고 직접 요청을 확인해보세요
Open
3 tasks
5 tasks
junha-ahn
requested changes
Oct 22, 2023
src/main/kotlin/com/group4/ticketingservice/controller/EventController.kt
Show resolved
Hide resolved
src/main/kotlin/com/group4/ticketingservice/controller/EventController.kt
Show resolved
Hide resolved
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
============================================
+ Coverage 82.60% 82.78% +0.17%
- Complexity 147 169 +22
============================================
Files 42 44 +2
Lines 730 784 +54
Branches 31 37 +6
============================================
+ Hits 603 649 +46
- Misses 104 109 +5
- Partials 23 26 +3
☔ View full report in Codecov by Sentry. |
junha-ahn
requested changes
Oct 25, 2023
Member
junha-ahn
left a comment
There was a problem hiding this comment.
last access id + 정렬기준 조건 테스트도 부탁드립니다.
last access id + price 등
Collaborator
Author
|
나머지 소팅방식 테스트 코드 추가하였고, |
src/integrationTest/kotlin/com/group4/ticketingservice/Event/EventRepositorySupportTest.kt
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR?
Key Changes
#122 에 나와있는 3가지의 정렬기준을 한개의 엔드포인트에서 응답하도록 만듬
querydsl을 사용하여 동적쿼리를 만들어서 적용함
최초 요청시에는 query parameter에 sort라는 이름의 키로 요청을 하면됌
"deadline" ->마감임박순
"startDate" -> 곧다가오는 공연
"createdAt " -> 생성일자
ex)localhost:8081/events?sort=created
value는 위 3개 가 될수있으며 sort를 요청안할시에는 id로 자동 정렬됌
ex)localhost:8081/events
최초 요청이후에는 sort는 계속 같이 보내되
앞선 요청한 데이터 10개중 마지막 데이터의 id와time을 같이 보내야함
ex)localhost:8081/events?sort=createdAt&id=2433031&time=2025-10-15T00:00:00Z
Test Checklist