Removes logfile deletion in the absence of an index file.#5
Open
king5327 wants to merge 1 commit intof-list:masterfrom
Open
Removes logfile deletion in the absence of an index file.#5king5327 wants to merge 1 commit intof-list:masterfrom
king5327 wants to merge 1 commit intof-list:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fully regenerate an index file, two things need to happen:
In the absence of an existing index file, the relevant log file should not be deleted and the log tool should skip that file for now. If the user is specifically concerned about that channel, chances are they'll access it (which will generate a blank index that can be used in the next repair attempt).
The log file is valuable. Deleting it because an easily-constructed companion is missing is a poor sequence of events, especially given that most normal f-chat interactions don't depend on the index. In the absence of an index file, chatting and saving the logs still functions completely fine, as does loading the last 20 posts.