feat: add --timeout/-t flag for initialization timeout #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Fixed lint issues introduced by this PR (gofmt formatting, empty-block). Note: The golangci-lint CI check was already failing on main/master before this PR (see run 19383105784). This PR actually reduces the total issue count from 11 to 8 by fixing formatting issues in files I touched. The remaining 8 issues are pre-existing in the codebase (goconst in web.go, gocritic in new.go, gocyclo in call.go, gofmt in transport_test.go, revive in test_helpers.go). |
Adds a configurable timeout for MCP server initialization: - Default remains 10 seconds (matching current behavior) - Can be set via --timeout or -t flag - Includes tests for timeout flag parsing
natsirtguy
force-pushed
the
feat/timeout
branch
from
d8ebcce to
7c5e248
Compare
Contributor
Author
|
I rebased onto the commit that fixes the pre-existing linting issues, so should be good to go now. I also changed the default back to 10 seconds to maintain behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a configurable
--timeout/-tflag for MCP server initialization timeout.Default is 30 seconds. Useful when connecting to slow-starting servers.
Changes
FlagTimeout/FlagTimeoutShortconstants andInitTimeoutvariable inroot.goutils.goandcall.goCreateClientFunc()for initialization timeoutUsage