Skip to content

Commit

Permalink
Code review 02/21
Browse files Browse the repository at this point in the history
  • Loading branch information
samoncrief committed Feb 21, 2025
1 parent 48a4532 commit 08f04d7
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions vtkext/private/module/vtkF3DOverlayRenderPass.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

vtkStandardNewMacro(vtkF3DOverlayRenderPass);

// ----------------------------------------------------------------------------
void vtkF3DOverlayRenderPass::Render(const vtkRenderState* s)
{
this->Initialize(s);
Expand All @@ -43,6 +44,7 @@ void vtkF3DOverlayRenderPass::Render(const vtkRenderState* s)
this->CompositeOverlay(s);
}

// ----------------------------------------------------------------------------
void vtkF3DOverlayRenderPass::ReleaseGraphicsResources(vtkWindow* w)
{
this->Superclass::ReleaseGraphicsResources(w);
Expand All @@ -65,6 +67,7 @@ void vtkF3DOverlayRenderPass::ReleaseGraphicsResources(vtkWindow* w)
}
}

// ----------------------------------------------------------------------------
void vtkF3DOverlayRenderPass::Initialize(const vtkRenderState* s)
{
this->OverlayProps.clear();
Expand All @@ -74,7 +77,7 @@ void vtkF3DOverlayRenderPass::Initialize(const vtkRenderState* s)
for (int i = 0; i < s->GetPropArrayCount(); i++)
{
vtkProp* prop = props[i];
if (!vtkSkybox::SafeDownCast(prop) && !vtkProp3D::SafeDownCast(prop))
if (!vtkProp3D::SafeDownCast(prop))
{
this->OverlayProps.push_back(prop);
}
Expand All @@ -99,6 +102,7 @@ void vtkF3DOverlayRenderPass::Initialize(const vtkRenderState* s)
this->OverlayPass->SetColorFormat(vtkTextureObject::Float32);
}

// ----------------------------------------------------------------------------
void vtkF3DOverlayRenderPass::CompositeOverlay(const vtkRenderState* s)
{
vtkOpenGLClearErrorMacro();
Expand Down Expand Up @@ -226,4 +230,4 @@ void vtkF3DOverlayRenderPass::CompositeOverlay(const vtkRenderState* s)
this->ColorTexture->Deactivate();

vtkOpenGLCheckErrorMacro("failed after Render");
}
}

0 comments on commit 08f04d7

Please sign in to comment.