Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecated input usage #1151

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Fix deprecated input usage #1151

merged 1 commit into from
Jan 10, 2024

Conversation

mwestphal
Copy link
Member

No description provided.

@mwestphal mwestphal changed the base branch from master to release January 9, 2024 21:57
@mwestphal mwestphal mentioned this pull request Jan 9, 2024
Open
@mwestphal mwestphal requested a review from Meakk January 9, 2024 21:59
@mwestphal
Copy link
Member Author

FYI @snoyer

@mwestphal mwestphal added this to the 2.3.0 milestone Jan 9, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (25281eb) 96.22% compared to head (7f9964c) 96.34%.
Report is 97 commits behind head on release.

Files Patch % Lines
plugins/assimp/module/vtkF3DAssimpImporter.cxx 36.36% 14 Missing ⚠️
plugins/usd/module/vtkF3DUSDImporter.cxx 98.34% 8 Missing ⚠️
...y/VTKExtensions/Rendering/vtkF3DPolyDataMapper.cxx 77.77% 6 Missing ⚠️
application/F3DStarter.cxx 96.55% 1 Missing ⚠️
plugins/alembic/module/vtkF3DAlembicReader.cxx 99.51% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           release    #1151      +/-   ##
===========================================
+ Coverage    96.22%   96.34%   +0.12%     
===========================================
  Files          120      129       +9     
  Lines         7015     7860     +845     
===========================================
+ Hits          6750     7573     +823     
- Misses         265      287      +22

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Meakk
Meakk approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@Meakk Meakk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mwestphal mwestphal merged commit 8a2b9da into f3d-app:release Jan 10, 2024
mwestphal added a commit that referenced this pull request Feb 10, 2024
@mwestphal
Merge pull request #1151 from mwestphal/fix_deprecated_input_usage
8b1cc9b 
Fix deprecated input usage
mwestphalnew pushed a commit to mwestphalnew/f3d that referenced this pull request Feb 10, 2024
@mwestphal
Merge pull request f3d-app#1151 from mwestphal/fix_deprecated_input_u…
25aad66 
…sage

Fix deprecated input usage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meakk Meakk Meakk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mwestphal @Meakk