Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USD: Add support for face-varying #1169

Merged
merged 27 commits into from
Jan 17, 2024
Merged

USD: Add support for face-varying #1169

merged 27 commits into from
Jan 17, 2024
+396 −91

Conversation

Meakk
Copy link
Member

@Meakk Meakk commented Jan 12, 2024 •
edited
Loading

@Meakk Meakk self-assigned this Jan 12, 2024
@Meakk Meakk changed the base branch from master to release January 12, 2024 17:40
@Meakk Meakk mentioned this pull request Jan 16, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Jan 16, 2024 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (0dbc87d) 96.34% compared to head (2e0acf2) 96.42%.
Report is 9 commits behind head on release.

Files Patch % Lines
plugins/usd/module/vtkF3DUSDImporter.cxx 98.41% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           release    #1169      +/-   ##
===========================================
+ Coverage    96.34%   96.42%   +0.07%     
===========================================
  Files          129      131       +2     
  Lines         7861     8000     +139     
===========================================
+ Hits          7574     7714     +140     
+ Misses         287      286       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Meakk Meakk requested a review from mwestphal January 16, 2024 17:47
mwestphal
mwestphal requested changes Jan 16, 2024
View reviewed changes
Copy link
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naming changes and coverage improvements needed

mwestphal
mwestphal requested changes Jan 17, 2024
View reviewed changes
Copy link
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes

@mwestphal mwestphal self-requested a review January 17, 2024 11:52
@Meakk Meakk merged commit 3128d4f into f3d-app:release Jan 17, 2024
@Meakk Meakk deleted the usd-facevarying branch January 17, 2024 17:54
mwestphal pushed a commit that referenced this pull request Feb 10, 2024
@Meakk
USD: Add support for face-varying (#1169)
2b6c07f
mwestphalnew pushed a commit to mwestphalnew/f3d that referenced this pull request Feb 10, 2024
@Meakk
USD: Add support for face-varying (f3d-app#1169)
5675ba5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwestphal mwestphal

Assignees

@Meakk Meakk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Meakk @mwestphal