Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Android/Wasm CI #1950

Merged
merged 6 commits into from
Mar 16, 2025
Merged

Rework Android/Wasm CI #1950

merged 6 commits into from
Mar 16, 2025

Conversation

Meakk
Copy link
Member

@Meakk Meakk commented Jan 28, 2025

  • Rework the CI related to Android in order to use Docker images with prebuilt dependencies instead
  • Enable more plugins to the Android CI
  • Move wasm to the CI workflow and uses the new VTK-versioned Docker images

@Meakk Meakk self-assigned this Jan 28, 2025
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.81%. Comparing base (a40472d) to head (c4fa16b).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1950   +/-   ##
=======================================
  Coverage   95.81%   95.81%           
=======================================
  Files         128      128           
  Lines       10541    10541           
=======================================
  Hits        10100    10100           
  Misses        441      441           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mwestphal
Copy link
Contributor

How do we change vtk version then ?

@Meakk
Copy link
Member Author

Meakk commented Jan 28, 2025

How do we change vtk version then ?

In the Docker image directly, just like we do with wasm

@mwestphal
Copy link
Contributor

I don't like the wasm approach TBH, let's discuss this.

@Meakk Meakk force-pushed the android-ci branch 2 times, most recently from 1846fbc to 8fdadb4 Compare March 1, 2025 15:25
@Meakk Meakk changed the title [draft] Rework Android CI Rework Android/Wasm CI Mar 2, 2025
@Meakk Meakk requested a review from mwestphal March 2, 2025 14:22
Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some questions

@Meakk Meakk merged commit 1f5dbc0 into f3d-app:master Mar 16, 2025
54 checks passed
@Meakk Meakk deleted the android-ci branch March 16, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants