-
-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework Android/Wasm CI #1950
Rework Android/Wasm CI #1950
Conversation
Meakk
commented
Jan 28, 2025
•
edited
Loading
edited
- Rework the CI related to Android in order to use Docker images with prebuilt dependencies instead
- Enable more plugins to the Android CI
- Move wasm to the CI workflow and uses the new VTK-versioned Docker images
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1950 +/- ##
=======================================
Coverage 95.81% 95.81%
=======================================
Files 128 128
Lines 10541 10541
=======================================
Hits 10100 10100
Misses 441 441 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
How do we change vtk version then ? |
In the Docker image directly, just like we do with wasm |
I don't like the wasm approach TBH, let's discuss this. |
1846fbc
to
8fdadb4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some questions