Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding color as a proper option type #1967

Merged
merged 18 commits into from
Feb 16, 2025
Merged

Adding color as a proper option type #1967

merged 18 commits into from
Feb 16, 2025

Conversation

mwestphal
Copy link
Contributor

@mwestphal mwestphal commented Feb 4, 2025 •
edited
Loading

  • Add a std::array based color_t in types.h
  • Use it for apropriate options
  • Add testing
  • Update doc

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: python, java, webassembly.

@codecov Codecov
Copy link

codecov bot commented Feb 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.61%. Comparing base (2ac4c07) to head (2d9d084).
Report is 8 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1967      +/-   ##
==========================================
- Coverage   95.62%   95.61%   -0.02%     
==========================================
  Files         125      125              
  Lines       10022    10063      +41     
==========================================
+ Hits         9584     9622      +38     
- Misses        438      441       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwestphal mwestphal changed the title [draft] libf3d: Adding color_t Adding color as a proper options type Feb 5, 2025
mwestphal
mwestphal commented Feb 5, 2025
View reviewed changes
@mwestphal
Copy link
Contributor Author

@snoyer @Meakk please review

@mwestphal mwestphal requested a review from Meakk February 5, 2025 22:25
@mwestphal mwestphal changed the title Adding color as a proper options type Adding color as a proper option type Feb 5, 2025
Meakk
Meakk requested changes Feb 6, 2025
View reviewed changes
@mwestphal mwestphal requested review from snoyer and Meakk February 6, 2025 21:42
snoyer
snoyer reviewed Feb 7, 2025
View reviewed changes
Meakk
Meakk requested changes Feb 12, 2025
View reviewed changes
@mwestphal mwestphal merged commit 21b065f into f3d-app:master Feb 16, 2025
55 checks passed
@mwestphal mwestphal mentioned this pull request Feb 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snoyer snoyer snoyer left review comments

@michaelmigliore michaelmigliore michaelmigliore left review comments

@Meakk Meakk Meakk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mwestphal @snoyer @Meakk @michaelmigliore