CI: Add a config.json file for deps versions #1968
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meakk
changed the title
mwestphal
reviewed
Feb 5, 2025
mwestphal
reviewed
Feb 5, 2025
| @@ -29,6 +29,9 @@ inputs: | |||
| usd_version: | |||
| description: 'Version of usd to build' | |||
| required: false | |||
| vtk_version: | |||
| description: 'Version of vtk to build' | |||
| required: false | |||
There was a problem hiding this comment.
should have a default or be required
mwestphal
reviewed
Feb 5, 2025
| inputs: | ||
| vtk_version: | ||
| description: 'Version of vtk to build' | ||
| required: false |
There was a problem hiding this comment.
should have a default or be required
mwestphal
reviewed
Feb 5, 2025
| @@ -8,7 +8,6 @@ inputs: | |||
| vtk_version: | |||
| description: 'VTK version' | |||
| required: false | |||
| default: 'commit' | |||
There was a problem hiding this comment.
should have a default or be required
mwestphal
reviewed
Feb 5, 2025
| @@ -31,6 +31,9 @@ inputs: | |||
| usd_version: | |||
| description: 'Version of usd to build' | |||
| required: false | |||
| vtk_version: | |||
| description: 'Version of vtk to build' | |||
| required: false | |||
There was a problem hiding this comment.
should have a default or be required
mwestphal
reviewed
Feb 5, 2025
| @@ -7,7 +7,6 @@ inputs: | |||
| vtk_version: | |||
| description: 'VTK version' | |||
| required: false | |||
| default: 'commit' | |||
There was a problem hiding this comment.
should have a default or be required
mwestphal
reviewed
Feb 5, 2025
| shell: bash | ||
| run: echo "VTK_SHA_OR_TAG=${{inputs.vtk_version}}" >> $GITHUB_ENV | ||
| run: | | ||
| [[ "${{ inputs.vtk_version }}" ]] || { echo "vtk_version input is empty" ; exit 1; } |
There was a problem hiding this comment.
check both in a single step ?
mwestphal
reviewed
Feb 5, 2025
| shell: bash | ||
| run: echo "VTK_SHA_OR_TAG=${{inputs.vtk_version}}" >> $GITHUB_ENV | ||
| run: | | ||
| [[ "${{ inputs.vtk_version }}" ]] || { echo "vtk_version input is empty" ; exit 1; } |
There was a problem hiding this comment.
check both in a single step
mwestphal
reviewed
Feb 5, 2025
.github/workflows/ci.yml
Outdated
| uses: ./source/.github/actions/default-versions | ||
| - name: Read JSON file | ||
| id: get_config | ||
| run: echo "config=$(jq -c . < ./source/.github/workflows/config.json)" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
maybe its better to have a dedicated action read and provide individual var instead of using fromJson everywhere ?
mwestphal
reviewed
Feb 5, 2025
.github/workflows/ci.yml
Outdated
| #---------------------------------------------------------------------------- | ||
| default_versions: | ||
| config_file: |
There was a problem hiding this comment.
I dont like this job name. config file are aleady a thing in f3d, lets avoid confusion.
mwestphal
reviewed
Feb 5, 2025
.github/workflows/config.json
Outdated
| "Alembic is part of VFX reference platform (CY2025: 1.8.x)", | ||
| "OpenEXR is part of VFX reference platform (CY2025: 3.3.x)", | ||
| "OpenVDB is part of VFX reference platform (CY2025: 12.x))", | ||
| "OpenVDB min version is not enforced by F3D code and missing from VTK code)", |
There was a problem hiding this comment.
Suggested change
| "OpenVDB min version is not enforced by F3D code and missing from VTK code)", | |
| "OpenVDB min version is not enforced by F3D code and missing from VTK code", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.