Add a new option type: direction_t #2007
Conversation
mwestphal
commented
Feb 20, 2025
•
mwestphal
commented
- Add a new option type: direction_t
- Use it for up-direction and modify implementation accordingly
- Use parsing of direction for camera-direction
- Add doc and testing
|
You are modifying libf3d public API! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2007 +/- ##
==========================================
+ Coverage 95.68% 95.71% +0.02%
==========================================
Files 126 126
Lines 10198 10266 +68
==========================================
+ Hits 9758 9826 +68
Misses 440 440 ☔ View full report in Codecov by Sentry. |
mwestphal
force-pushed
the
direction_t
branch
from
91dd133 to
274aeee
Compare
mwestphal
force-pushed
the
direction_t
branch
from
3b49378 to
198577b
Compare
mwestphal
force-pushed
the
direction_t
branch
from
4852459 to
abb49be
Compare
| @@ -74,10 +74,6 @@ int TestSDKOptions(int argc, char* argv[]) | |||
| test("set/get string", std::get<std::string>(opt.get("model.color.texture")) == "test"); | |||
|
|
|||
| // Test double vector | |||
| std::stringstream ssDouble; | |||
| ssDouble << std::vector<double>{ 1.1, 2., 3. }; | |||
There was a problem hiding this comment.
@Meakk I had to remove this test because the constructor for color_t and direction_t are not explicit.
It fails to compile because the compiler is not able to figure out which type should be used for this << operator.
So maybe you are right on that regard ?
I could add them but it requires some work in the cmake code generation stuff.
There was a problem hiding this comment.
Yes I still think the constructor should be explicit. I don't like the idea of the compiler having the freedom the implicitly convert types.
There was a problem hiding this comment.
something like that @Meakk ?
