options: Add support for deprecating option in CMake logic #2011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwestphal
force-pushed
the
support_deprecating_option
branch
from
01aacf0 to
80ea359
Compare
mwestphal
force-pushed
the
support_deprecating_option
branch
from
80ea359 to
30ee37e
Compare
Meakk
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cmake logic in f3dOptions.cmake to be able to deprecated an option.
Actual deprecation example:
01aacf0
Result in CI (look for
show_edgesin log): https://github.com/f3d-app/f3d/actions/runs/13482909819/job/37670441340?pr=2011Fix: #1568