Options: Add support for "--reset-option-name" for libf3d options #2013
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2013 +/- ##
==========================================
- Coverage 95.68% 95.67% -0.02%
==========================================
Files 126 126
Lines 10198 10238 +40
==========================================
+ Hits 9758 9795 +37
- Misses 440 443 +3 ☔ View full report in Codecov by Sentry. |
mwestphal
force-pushed
the
default_cli_option
branch
from
250d863 to
633d2c5
Compare
| @@ -162,6 +162,8 @@ As documented, only the `--option=value` syntax is supported. The syntax `--opti | |||
|
|
|||
| All options are parsed according to their type, see the [parsing documentation](PARSING.md) for more details. | |||
|
|
|||
| It is possible to reset [libf3d options](../libf3d/OPTIONS.md) to their default value using the `--options=Default` syntax. | |||
There was a problem hiding this comment.
I'm not completely convinced this is the right approach. wdyt @Meakk ?
There was a problem hiding this comment.
I don't like it tbh.
What about --reset-coloring-scalar-bar?
Warning handling in GCC do something similar with -Wfoo/-Wno-foo.
It may be a bit trickier to implement but I'd prefer something like that.
There was a problem hiding this comment.
Something like that @Meakk ?
There was a problem hiding this comment.
Yes I think it's better and avoid potential issue with the reserved keyword.
mwestphal
changed the title
Fix #1623