Fix issue #201 : add PDAL reader #2014
Conversation
| "options": { | ||
| "load-plugins": "pdal", | ||
| "volume": true, | ||
| "volume-inverse": true |
There was a problem hiding this comment.
I dont think pdal formats should be opened as volumes though
There was a problem hiding this comment.
I'll remove both volume and volume-inverse, since i don't exactly what they do , i read this :
{"volume", "v", "Show volume if the file is compatible", "", "1"},
{"volume-inverse", "i", "Inverse opacity function for volume rendering", "", "1"} } },
but i'm not sure exactly what that's means, and if that needed.
There was a problem hiding this comment.
these .json file are the "default" config file that we install for each plugin.
For vdb, it makes sens to use volume rendering because in essence vdb format contains volume not surfaces or point cloud.
In you case, you may want to enable point-sprites.
In short, whatever option we may need to make the rendering look as expected by the user, we should put here.
You can just remove the volume part for now, just keep the load-plugins part. We will choose together the right options once this work is more advanced.
| "options": { | ||
| "load-plugins": "pdal", | ||
| "volume": true, | ||
| "volume-inverse": true |
There was a problem hiding this comment.
I dont think pdal formats should be opened as volumes though
There was a problem hiding this comment.
I'll remove both volume and volume-inverse, since i don't exactly what they do , i read this :
{"volume", "v", "Show volume if the file is compatible", "", "1"},
{"volume-inverse", "i", "Inverse opacity function for volume rendering", "", "1"} } },
but i'm not sure exactly what that's means, and if that needed.
There was a problem hiding this comment.
lets discuss it here: #2014 (comment)
plugins/pdal/f3d-pdal-formats.xml
Outdated
| @@ -0,0 +1,7 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <mime-info xmlns="http://www.freedesktop.org/standards/shared-mime-info"> | |||
| <mime-type type="application/vnd.pdal"> | |||
There was a problem hiding this comment.
I dont think this is correct:
https://www.iana.org/assignments/media-types/media-types.xhtml
Search for vnd.las
There was a problem hiding this comment.
i see https://www.iana.org/assignments/media-types/application/vnd.las
i'll fix this
plugins/CMakeLists.txt
Outdated
|
|
||
| if (F3D_PLUGIN_BUILD_PDAL) | ||
| add_subdirectory(pdal) | ||
| endif() |
There was a problem hiding this comment.
do you mean at the end of the file ?
CMakeLists.txt
Outdated
| @@ -109,6 +109,7 @@ find_package(VTK 9.2.6 REQUIRED | |||
| opengl | |||
| IOExodus | |||
| IOOpenVDB | |||
| IOPDAL | |||
There was a problem hiding this comment.
looks like you used a tab here, lets use spaces
There was a problem hiding this comment.
i'll change this in my editor settings.
Implemented initial PDAL support that currently handles only LAS file formats, laying the groundwork for future enhancements and additional file format integration.