Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F3D: Add support for -D, --define and -R,--reset CLI option to set/reset libf3d options from CLI #2035

Merged
merged 8 commits into from
Mar 3, 2025

Conversation

mwestphal
Copy link
Member

@mwestphal mwestphal commented Mar 2, 2025

  • Add support for -D/--define by handling it in the CLI options parsing and converting to proper libf3d option names
  • Add support for -R/--reset by using a dedication reset-* syntax in the CLI options handling
  • Add testing for define and resets
  • Fix an issue when reseting an option from the interactive command line and add testing
  • Clarify behavior in regards to forced libf3d options
  • Fix a small logging issue
  • Update doc acccordingly
  • Rework some map access code to avoid duplicate lookups
  • Fix a few tests that were missing NO_OUTPUT

Fix: #1600

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.78%. Comparing base (413e7a0) to head (d65e335).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2035      +/-   ##
==========================================
+ Coverage   95.76%   95.78%   +0.01%     
==========================================
  Files         128      128              
  Lines       10396    10433      +37     
==========================================
+ Hits         9956     9993      +37     
  Misses        440      440              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Meakk Meakk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@mwestphal mwestphal merged commit ba52a40 into f3d-app:master Mar 3, 2025
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a -D --define option to set libf3d options directly
2 participants