Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

options: Add path_t and use it for hdri #2045

Closed
wants to merge 2 commits into from

Conversation

mwestphal
Copy link
Member

No description provided.

Copy link

github-actions bot commented Mar 5, 2025

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: python, java, webassembly.

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.80%. Comparing base (c7f7a99) to head (14099e5).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2045      +/-   ##
==========================================
- Coverage   95.80%   95.80%   -0.01%     
==========================================
  Files         128      128              
  Lines       10488    10505      +17     
==========================================
+ Hits        10048    10064      +16     
- Misses        440      441       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Meakk
Copy link
Member

Meakk commented Mar 5, 2025

Any reason to not use std::filesystem::path?

@mwestphal
Copy link
Member Author

Any reason to not use std::filesystem::path?

Im using std::filesystem::path already, inside of path_t. Its required to be done like this as std::filesystem::path is not part of the variant API. Adding a new type to the variant API is a possibility but I'd rather not.

@mwestphal
Copy link
Member Author

nevermind you are right @Meakk , I can use std::filesystem::path directly

@mwestphal mwestphal closed this Mar 5, 2025
@mwestphal mwestphal reopened this Mar 5, 2025
@mwestphal
Copy link
Member Author

actually a valid approach compared to #2046

@mwestphal mwestphal closed this Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants