Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

context: Add exception handling #2064

Merged
merged 7 commits into from
Mar 16, 2025

Conversation

exbluesbreaker
Copy link
Contributor

Related to #1727

@exbluesbreaker
Copy link
Contributor Author

I do not know yet how to test all of the exceptions, I know there are already existing test case for not supported GL wrappers, but I am not sure how to test other exception being returned in f3d application. I saw some fabricated code in unit tests, only.

@mwestphal
Copy link
Contributor

Some of these are already tested:

  • TestRenderingBackendWGLFailure
  • TestRenderingBackendGLXNoDisplay

Lets see what coverage says and we will see what we need to add

Copy link

codecov bot commented Mar 14, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.81%. Comparing base (9d5bc10) to head (4f5465b).
Report is 34 commits behind head on master.

Files with missing lines Patch % Lines
application/F3DStarter.cxx 88.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2064      +/-   ##
==========================================
+ Coverage   95.79%   95.81%   +0.01%     
==========================================
  Files         128      128              
  Lines       10485    10558      +73     
==========================================
+ Hits        10044    10116      +72     
- Misses        441      442       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Essentially changed internals to unique_ptr
Copy link

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: python, java, webassembly.

@exbluesbreaker
Copy link
Contributor Author

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️! You can find them in their respective directories: python, java, webassembly.

Oops

Also remove symbol loading exception catch as it should not be possible
to happen in this place unless GL wrapper library is faulty somehow
@exbluesbreaker
Copy link
Contributor Author

Can somebody have a look about bindings. I changed Internals field in engine from raw to unique_ptr, it doesn't seem it is directly provided in bindings

@exbluesbreaker
Copy link
Contributor Author

exbluesbreaker commented Mar 14, 2025

Ok, Windows also complains about exporting now, I guess I will just went back to raw pointer and add deallocation.

Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but lets give some time for @Meakk to review

@mwestphal mwestphal merged commit 877959f into f3d-app:master Mar 16, 2025
53 of 54 checks passed
@mwestphal
Copy link
Contributor

Thanks for the contribution @exbluesbreaker !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants