-
-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
context: Add exception handling #2064
context: Add exception handling #2064
Conversation
I do not know yet how to test all of the exceptions, I know there are already existing test case for not supported GL wrappers, but I am not sure how to test other exception being returned in f3d application. I saw some fabricated code in unit tests, only. |
Some of these are already tested:
Lets see what coverage says and we will see what we need to add |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2064 +/- ##
==========================================
+ Coverage 95.79% 95.81% +0.01%
==========================================
Files 128 128
Lines 10485 10558 +73
==========================================
+ Hits 10044 10116 +72
- Misses 441 442 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Essentially changed internals to unique_ptr
You are modifying libf3d public API! |
Oops |
Also remove symbol loading exception catch as it should not be possible to happen in this place unless GL wrapper library is faulty somehow
Can somebody have a look about bindings. I changed |
Ok, Windows also complains about exporting now, I guess I will just went back to raw pointer and add deallocation. |
Also move test case location
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved but lets give some time for @Meakk to review
Thanks for the contribution @exbluesbreaker ! |
Related to #1727