-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colormap parse format #2066
Colormap parse format #2066
Conversation
You are modifying libf3d public API! |
891900d
to
98ef7e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- library/private/options_tools.h
- lines 482-482
98ef7e7
to
f5ca329
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- doc/libf3d/OPTIONS.md
- lines 42-65
e6f76b6
to
66c3939
Compare
66c3939
to
9e414ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- doc/libf3d/OPTIONS.md
- lines 42-65
- library/testing/TestSDKOptions.cxx
- lines 170-171
- library/testing/TestSDKOptionsIO.cxx
- lines 197-201
b18b3b9
to
efde5fe
Compare
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…olormap_parse_format
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2066 +/- ##
=======================================
Coverage 95.78% 95.78%
=======================================
Files 125 123 -2
Lines 10655 10656 +1
=======================================
+ Hits 10206 10207 +1
Misses 449 449 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! LGTM
val, color, val, color
is now supported