Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colormap parse format #2066

Merged
merged 10 commits into from
Mar 25, 2025
Merged

Conversation

mwestphal
Copy link
Member

@mwestphal mwestphal commented Mar 15, 2025

  • Add proper colormap parsing and formating : val, color, val, color is now supported
  • Add documentation
  • Add testing
  • Fix/Improve related doc

Copy link

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: python, java, webassembly.

@mwestphal mwestphal force-pushed the colormap_parse_format branch from 891900d to 98ef7e7 Compare March 24, 2025 20:56
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • library/private/options_tools.h
    • lines 482-482

@mwestphal mwestphal force-pushed the colormap_parse_format branch from 98ef7e7 to f5ca329 Compare March 24, 2025 20:58
@mwestphal mwestphal marked this pull request as ready for review March 24, 2025 20:59
@mwestphal mwestphal changed the title [draft] Colormap parse format Colormap parse format Mar 24, 2025
@mwestphal mwestphal added this to the 3.1.0 milestone Mar 24, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • doc/libf3d/OPTIONS.md
    • lines 42-65

@mwestphal mwestphal force-pushed the colormap_parse_format branch from e6f76b6 to 66c3939 Compare March 25, 2025 18:32
@mwestphal mwestphal force-pushed the colormap_parse_format branch from 66c3939 to 9e414ce Compare March 25, 2025 18:33
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • doc/libf3d/OPTIONS.md
    • lines 42-65
  • library/testing/TestSDKOptions.cxx
    • lines 170-171
  • library/testing/TestSDKOptionsIO.cxx
    • lines 197-201

@mwestphal mwestphal force-pushed the colormap_parse_format branch from b18b3b9 to efde5fe Compare March 25, 2025 19:45
mwestphal and others added 3 commits March 25, 2025 20:46
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mwestphal mwestphal requested a review from Meakk March 25, 2025 20:13
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 97.82609% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.78%. Comparing base (0beb460) to head (f86533d).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
library/private/options_tools.h 97.82% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2066   +/-   ##
=======================================
  Coverage   95.78%   95.78%           
=======================================
  Files         125      123    -2     
  Lines       10655    10656    +1     
=======================================
+ Hits        10206    10207    +1     
  Misses        449      449           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@Meakk Meakk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM

@mwestphal mwestphal merged commit bba1b0f into f3d-app:master Mar 25, 2025
103 of 104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants