Add ImGui Minimal Console Feature #2099

wizzebit · 2025-03-28T10:21:33Z

Addresses #1817

new option ui.minimal_console
minimal console feature added to vtkext/private/module/vtkF3DImguiConsole.cxx

…n for minimal console mode

…ImGUI-minimal

library/src/interactor_impl.cxx

vtkext/private/module/vtkF3DImguiConsole.cxx

vtkext/private/module/vtkF3DImguiConsole.h

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

vtkext/private/module/vtkF3DImguiConsole.cxx

vtkext/private/module/vtkF3DImguiConsole.h

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

vtkext/private/module/vtkF3DImguiConsole.cxx

vtkext/private/module/vtkF3DImguiConsole.h

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

vtkext/private/module/vtkF3DImguiConsole.cxx

vtkext/private/module/vtkF3DImguiConsole.h

- added HideMinimalConsoleEvent - changed OPTIONS.md description for minimal_console

vtkext/private/module/vtkF3DImguiConsole.cxx

vtkext/private/module/vtkF3DImguiConsole.h

vtkext/private/module/vtkF3DImguiConsole.cxx

vtkext/private/module/vtkF3DImguiConsole.h

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

vtkext/private/module/vtkF3DImguiConsole.h

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

github-actions

Some suggestions could not be made:

vtkext/private/module/vtkF3DImguiConsole.h
- lines 50-50

github-actions

Some suggestions could not be made:

vtkext/private/module/vtkF3DImguiConsole.cxx
- lines 236-237

library/src/interactor_impl.cxx

vtkext/private/module/vtkF3DImguiConsole.cxx

github-actions

Some suggestions could not be made:

vtkext/private/module/vtkF3DImguiConsole.cxx
- lines 236-237

library/src/interactor_impl.cxx

vtkext/private/module/vtkF3DImguiConsole.cxx

github-actions

Some suggestions could not be made:

vtkext/private/module/vtkF3DImguiConsole.cxx
- lines 234-235

library/src/interactor_impl.cxx

vtkext/private/module/vtkF3DImguiConsole.cxx

github-actions

Some suggestions could not be made:

vtkext/private/module/vtkF3DImguiConsole.cxx
- lines 234-235

vtkext/private/module/vtkF3DImguiConsole.cxx

github-actions

Some suggestions could not be made:

vtkext/private/module/vtkF3DImguiConsole.cxx
- lines 219-331

github-actions

Some suggestions could not be made:

vtkext/private/module/vtkF3DImguiConsole.cxx
- lines 221-333

github-actions

Some suggestions could not be made:

vtkext/private/module/vtkF3DImguiConsole.cxx
- lines 234-235

library/src/interactor_impl.cxx

vtkext/private/module/vtkF3DImguiConsole.cxx

github-actions

Some suggestions could not be made:

vtkext/private/module/vtkF3DImguiConsole.cxx
- lines 234-235

library/src/interactor_impl.cxx

vtkext/private/module/vtkF3DImguiConsole.cxx

library/src/interactor_impl.cxx

vtkext/private/module/vtkF3DImguiConsole.cxx

…ImGUI-minimal

vtkext/private/module/vtkF3DUIActor.h

mwestphal

small changes needed

mwestphal · 2025-04-14T06:30:07Z

testing/baselines/TestInteractionMinimalConsoleResize.png

I wonder if badge and console should be put on the same height ? a bit out of scope of this PR though

mwestphal · 2025-04-14T06:30:34Z

application/testing/CMakeLists.txt

+f3d_test(NAME TestInteractionMinimalConsoleOpen DATA f3d.glb INTERACTION UI) #Colon
+f3d_test(NAME TestInteractionMinimalConsoleEscape DATA f3d.glb INTERACTION UI) #Colon;Escape
+f3d_test(NAME TestInteractionMinimalConsoleReturn DATA f3d.glb INTERACTION UI) #Colon;Return
+f3d_test(NAME TestInteractionMinimalConsoleValidCommand DATA f3d.glb INTERACTION UI) #Colon;clear;Return


Lets use a command with an actual visible effect, eg set_camera top

mwestphal

small change needed

wizzebit added 8 commits March 22, 2025 21:14

Added binding for minimal console mode, added option and documentatio…

3ca2e69

…n for minimal console mode

renamed option, added minimal console behavior

d81f926

Merge branch 'f3d-app:master' into ImGUI-minimal

721bbd3

extra functionality, need to make comments

f87d1db

Merge branch 'f3d-app:master' into ImGUI-minimal

6826c62

new version of minimal console

8cfc009

Merge branch 'ImGUI-minimal' of https://github.com/wizzebit/f3d into …

09f411c

…ImGUI-minimal

updated options.md

afb0c81

github-actions bot reviewed Mar 28, 2025

View reviewed changes

wizzebit and others added 3 commits March 28, 2025 06:23

Update library/src/interactor_impl.cxx

d8da20a

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update library/src/interactor_impl.cxx

0f8c910

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update vtkext/private/module/vtkF3DImguiConsole.cxx

4a6968a

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

github-actions bot reviewed Mar 28, 2025

View reviewed changes

vtkext/private/module/vtkF3DImguiConsole.cxx Outdated Show resolved Hide resolved

vtkext/private/module/vtkF3DImguiConsole.cxx Outdated Show resolved Hide resolved

vtkext/private/module/vtkF3DImguiConsole.h Outdated Show resolved Hide resolved

Update vtkext/private/module/vtkF3DImguiConsole.cxx

4cd259b

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

github-actions bot reviewed Mar 28, 2025

View reviewed changes

vtkext/private/module/vtkF3DImguiConsole.cxx Outdated Show resolved Hide resolved

vtkext/private/module/vtkF3DImguiConsole.cxx Outdated Show resolved Hide resolved

vtkext/private/module/vtkF3DImguiConsole.h Outdated Show resolved Hide resolved

github-actions bot reviewed Mar 28, 2025

View reviewed changes

vtkext/private/module/vtkF3DImguiConsole.h Outdated Show resolved Hide resolved

github-actions bot reviewed Mar 28, 2025

View reviewed changes

vtkext/private/module/vtkF3DImguiConsole.h Outdated Show resolved Hide resolved

Update vtkext/private/module/vtkF3DImguiConsole.cxx

ca8a7a8

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

github-actions bot reviewed Mar 28, 2025

View reviewed changes

vtkext/private/module/vtkF3DImguiConsole.cxx Outdated Show resolved Hide resolved

vtkext/private/module/vtkF3DImguiConsole.h Outdated Show resolved Hide resolved

minor fixes

66d100d

github-actions bot reviewed Mar 28, 2025

View reviewed changes

vtkext/private/module/vtkF3DImguiConsole.h Outdated Show resolved Hide resolved

wizzebit added 2 commits March 28, 2025 17:25

- changed minimal console format

84830af

- added HideMinimalConsoleEvent - changed OPTIONS.md description for minimal_console

Merge branch 'f3d-app:master' into ImGUI-minimal

cb29634

github-actions bot reviewed Mar 28, 2025

View reviewed changes

vtkext/private/module/vtkF3DImguiConsole.cxx Outdated Show resolved Hide resolved

vtkext/private/module/vtkF3DImguiConsole.h Outdated Show resolved Hide resolved

github-actions bot reviewed Mar 28, 2025

View reviewed changes

vtkext/private/module/vtkF3DImguiConsole.cxx Outdated Show resolved Hide resolved

vtkext/private/module/vtkF3DImguiConsole.h Outdated Show resolved Hide resolved

Update vtkext/private/module/vtkF3DImguiConsole.cxx

d264b9d

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

github-actions bot reviewed Mar 28, 2025

View reviewed changes

vtkext/private/module/vtkF3DImguiConsole.h Outdated Show resolved Hide resolved

wizzebit and others added 2 commits March 28, 2025 17:43

Update vtkext/private/module/vtkF3DImguiConsole.h

c920c8b

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update vtkext/private/module/vtkF3DImguiConsole.h

22d9533

github-actions bot reviewed Mar 28, 2025

View reviewed changes

github-actions bot reviewed Apr 4, 2025

View reviewed changes

library/src/interactor_impl.cxx Outdated Show resolved Hide resolved

vtkext/private/module/vtkF3DImguiConsole.cxx Outdated Show resolved Hide resolved

github-actions bot reviewed Apr 4, 2025

View reviewed changes

library/src/interactor_impl.cxx Outdated Show resolved Hide resolved

vtkext/private/module/vtkF3DImguiConsole.cxx Outdated Show resolved Hide resolved

Fixed unresponsive badge issue

e5ef03a

github-actions bot reviewed Apr 4, 2025

View reviewed changes

library/src/interactor_impl.cxx Outdated Show resolved Hide resolved

vtkext/private/module/vtkF3DImguiConsole.cxx Outdated Show resolved Hide resolved

github-actions bot reviewed Apr 4, 2025

View reviewed changes

vtkext/private/module/vtkF3DImguiConsole.cxx Outdated Show resolved Hide resolved

github-actions bot reviewed Apr 4, 2025

View reviewed changes

wizzebit force-pushed the ImGUI-minimal branch from 6bf7a17 to e5ef03a Compare April 4, 2025 11:02

Merge branch 'f3d-app:master' into ImGUI-minimal

463a92b

github-actions bot reviewed Apr 4, 2025

View reviewed changes

library/src/interactor_impl.cxx Outdated Show resolved Hide resolved

vtkext/private/module/vtkF3DImguiConsole.cxx Outdated Show resolved Hide resolved

github-actions bot reviewed Apr 4, 2025

View reviewed changes

library/src/interactor_impl.cxx Outdated Show resolved Hide resolved

vtkext/private/module/vtkF3DImguiConsole.cxx Outdated Show resolved Hide resolved

styling fixes

99493fa

github-actions bot reviewed Apr 4, 2025

View reviewed changes

library/src/interactor_impl.cxx Outdated Show resolved Hide resolved

vtkext/private/module/vtkF3DImguiConsole.cxx Outdated Show resolved Hide resolved

styling

b7f412d

wizzebit force-pushed the ImGUI-minimal branch from b8e9a0f to b7f412d Compare April 4, 2025 11:22

github-actions bot reviewed Apr 4, 2025

View reviewed changes

vtkext/private/module/vtkF3DImguiConsole.cxx Outdated Show resolved Hide resolved

styling

a45c06b

github-actions bot reviewed Apr 4, 2025

View reviewed changes

vtkext/private/module/vtkF3DImguiConsole.cxx Outdated Show resolved Hide resolved

wizzebit added 3 commits April 4, 2025 07:28

styling

31d4c02

styling

2291004

Merge branch 'ImGUI-minimal' of https://github.com/wizzebit/f3d into …

26a4296

…ImGUI-minimal

wizzebit requested a review from mwestphal April 4, 2025 11:31

mwestphal reviewed Apr 4, 2025

View reviewed changes

vtkext/private/module/vtkF3DUIActor.h Outdated Show resolved Hide resolved

mwestphal requested changes Apr 4, 2025

View reviewed changes

wizzebit added 3 commits April 4, 2025 15:41

Update vtkF3DUIActor.h

91fb582

Merge branch 'f3d-app:master' into ImGUI-minimal

30eb9a3

Added Minimal Console Interaction Tests

307fb93

mwestphal reviewed Apr 14, 2025

View reviewed changes

mwestphal requested changes Apr 14, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ImGui Minimal Console Feature #2099

Add ImGui Minimal Console Feature #2099

wizzebit commented Mar 28, 2025

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

mwestphal left a comment

mwestphal Apr 14, 2025

mwestphal Apr 14, 2025

mwestphal left a comment

Add ImGui Minimal Console Feature #2099

Are you sure you want to change the base?

Add ImGui Minimal Console Feature #2099

Conversation

wizzebit commented Mar 28, 2025

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

mwestphal left a comment

Choose a reason for hiding this comment

mwestphal Apr 14, 2025

Choose a reason for hiding this comment

mwestphal Apr 14, 2025

Choose a reason for hiding this comment

mwestphal left a comment

Choose a reason for hiding this comment