Skip to content

Fix QuakeMDL animation #2128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Apr 13, 2025
Merged

Fix QuakeMDL animation #2128

merged 21 commits into from
Apr 13, 2025

Conversation

mwestphal
Copy link
Member

@mwestphal mwestphal commented Apr 9, 2025

  • Rework of the animation code
  • Proper implementation of animation selection and time logic
  • Improving testing

TODO (not in this PR nor this release):

  • Frame selection
  • Frame interpolation
  • GroupSkin support
  • Skin selection support
  • Complete rework using resource parser for safe implementation

Copy link

codecov bot commented Apr 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.86%. Comparing base (8d04b92) to head (9f320ea).
Report is 195 commits behind head on release.

Additional details and impacted files
@@             Coverage Diff             @@
##           release    #2128      +/-   ##
===========================================
+ Coverage    95.67%   95.86%   +0.18%     
===========================================
  Files          125      127       +2     
  Lines         9947    11057    +1110     
===========================================
+ Hits          9517    10600    +1083     
- Misses         430      457      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • plugins/native/module/vtkF3DQuakeMDLImporter.cxx
    • lines 118-118
    • lines 213-216
    • lines 232-234
    • lines 417-417

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • plugins/native/module/vtkF3DQuakeMDLImporter.cxx
    • lines 123-124
    • lines 401-402

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • plugins/native/module/vtkF3DQuakeMDLImporter.cxx
    • lines 123-124
    • lines 399-400

@mwestphal mwestphal merged commit 2f9c2c6 into f3d-app:release Apr 13, 2025
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant