Skip to content

Application: Add a f3d-console application on Windows #2131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 13, 2025

Conversation

mwestphal
Copy link
Member

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • doc/libf3d/OPTIONS.md
    • lines 102-103
  • library/src/window_impl.cxx
    • lines 425-425

Copy link

codecov bot commented Apr 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.91%. Comparing base (8d04b92) to head (f7b209f).
Report is 194 commits behind head on release.

Additional details and impacted files
@@             Coverage Diff             @@
##           release    #2131      +/-   ##
===========================================
+ Coverage    95.67%   95.91%   +0.24%     
===========================================
  Files          125      127       +2     
  Lines         9947    11101    +1154     
===========================================
+ Hits          9517    10648    +1131     
- Misses         430      453      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • doc/libf3d/OPTIONS.md
    • lines 102-103
  • library/src/window_impl.cxx
    • lines 425-425

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • doc/libf3d/OPTIONS.md
    • lines 102-103
  • library/src/window_impl.cxx
    • lines 425-425

Copy link
Member

@Meakk Meakk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I think it would be great to test unicode strings during manual RC testing. This is confusing, and the official /SUBSYSTEM documentation doesn't really help.

@mwestphal
Copy link
Member Author

to test unicode strings during manual RC testing. This is confusing, and the official /SUBSYSTEM documentation doesn't really help.

Yup

@mwestphal mwestphal merged commit fcf68cd into f3d-app:release Apr 13, 2025
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants