-
-
Notifications
You must be signed in to change notification settings - Fork 269
Application: Add a f3d-console application on Windows #2131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- doc/libf3d/OPTIONS.md
- lines 102-103
- library/src/window_impl.cxx
- lines 425-425
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release #2131 +/- ##
===========================================
+ Coverage 95.67% 95.91% +0.24%
===========================================
Files 125 127 +2
Lines 9947 11101 +1154
===========================================
+ Hits 9517 10648 +1131
- Misses 430 453 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- doc/libf3d/OPTIONS.md
- lines 102-103
- library/src/window_impl.cxx
- lines 425-425
17a950d
to
d260389
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- doc/libf3d/OPTIONS.md
- lines 102-103
- library/src/window_impl.cxx
- lines 425-425
8f68e08
to
f7b209f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I think it would be great to test unicode strings during manual RC testing. This is confusing, and the official /SUBSYSTEM
documentation doesn't really help.
Yup |
No description provided.