-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for fabric3.0 #46
base: master
Are you sure you want to change the base?
Conversation
Just as commentary, patching with this I was able to install the library and everything seems fine, I don't have all the test tools and haven't addressed that. I did wonder why setup.py was removed as it should still install with a toml file. Unless this is part of the work in progress it's worth calling it out in the PR. |
The change from |
Ok, the tests are running again. I was missing a dependency. I'll try to see if I can fix the test failures. Failed docs are related to |
Thanks for poking at this. I don't have a lot of time to dig right now but hopefully sometime soon-ish. I did notice you set the dep to fabric>=3 - the backwards incompat changes in 3.x were quite minor (the big one was just dropping Py<3.6 support, which is handle-able by users' pips) so it's not clear to me what exactly broke here under 3.x. I think it's more likely the breakage was on 2.x (which was a total rewrite) and you should be able to set the pyproject field to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bitprophet I've highlighted the main changes. Others were stylistic changes. And indeed, at least from the pytest, there didn't seem to be anything drastically changed, the only one seems to be with parsing the docstring, if you can assign someone to take a look at that, that would be wonderful
@@ -1,6 +1,6 @@ | |||
from importlib import import_module | |||
|
|||
from invocations import docs, travis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
invocations.travis
was dropped.
@@ -2,8 +2,6 @@ | |||
File transfer functionality above and beyond basic ``put``/``get``. | |||
""" | |||
|
|||
from invoke.vendor import six |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
invoke
does not bundle six
, moved to str
Signed-off-by: Cristian Le <[email protected]>
2800b11
to
23c9aba
Compare
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
0920324
to
8cfc5c3
Compare
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
@bitprophet I hope the CIs here help. Please check the runs on my fork until the github action is enabled. Are you ok with updating the minimum python requirement to |
Python 3.7 has reached EOF, may by minimum python requirement should be 3.8 |
I'm supporting 2.7, 3.5, 3.6, 3.7, 3.8, 3.9, 3.10, 3.11, 3.12 with Fabric and Patchwork. Would be great if this could be merged without breaking support for 3.5+ (so I can easily remain on Fabric |
@SamuelMarks If you want, you can run these tests on your fork with the minimum Python version you wish, and report back the patches needed to make it compatible. I don't remember if I checked the minimum requirements below those versions |
@LecrisUT Only just got the chance. It should now support Python 2.7 (added the older |
@bitprophet Any movement on this? Thanks :) |
.format
to fstrings for more readabilityFixes: #41
Depends-on: #47