Skip to content

issues Search Results · repo:fac-13/HP-game language:JavaScript

Filter by

11 results
 (76 ms)

11 results

infac-13/HP-game (press backspace or delete to remove)

fac-13/HP-game
More CSS

img width= 487 alt= screen shot 2018-06-01 at 22 55 44 src= https://user-images.githubusercontent.com/25727036/40865175-f8f4ded6-65ee-11e8-8d2c-9cddc85b67b1.png img width= 445 alt= screen shot 2018-06-01 ...
  • helenzhou6
  • Opened 
    on Jun 1, 2018
  • #20

fac-13/HP-game
UX issue: Abrupt ending of the game

Pass down as a prop that the game is ending, stop generation of new moles and remove all timers before finishing the game.
  • helenzhou6
  • Opened 
    on Jun 1, 2018
  • #19

fac-13/HP-game
User feedback when successfully hit a mole

...like an X flashing (using setTimeOut)
feature
  • helenzhou6
  • Opened 
    on Jun 1, 2018
  • #18

fac-13/HP-game
Best not to use index as key

here you use the index as a key https://github.com/fac-13/HP-game/blob/6236bf676bcc88461f96a1abe83198422a012593/src/components/whackAMole/whackAMole.js#L74 You shouldn t use indices as keys in react ...
  • ZooeyMiller
  • Opened 
    on May 25, 2018
  • #15

fac-13/HP-game
Error handling the api request

At the moment if the request fails the app turns into a blank page with a log out button: broken This is because there s no error handling on the user fetch in form.js: https://github.com/fac-13/HP-game/blob/6236bf676bcc88461f96a1abe83198422a012593/src/components/form/form.js#L15-L21 ...
DONE
  • finnhodgkin
  • Opened 
    on May 25, 2018
  • #14

fac-13/HP-game
Bind `this` consistently

You have a combination of binding in the constructor and using arrow functions/class properties. It d probably be best to pick one and stick with it. (I appreciate that you re probably just practicing ...
  • oliverjam
  • Opened 
    on May 25, 2018
  • #13

fac-13/HP-game
<br />

Ew 😝 I don t think it s even really doing anything in this case. If you need stuff on a new line you should probably use CSS
DONE
  • oliverjam
  • Opened 
    on May 25, 2018
  • #12

fac-13/HP-game
UNSAFE_componentWillMount()

You probably don t need to use UNSAFE_componentWillMount()—you can start the game inside componentDidMount()`. Is there any reason you picked this lifecycle instead?
DONE
  • oliverjam
  • Opened 
    on May 25, 2018
  • #10

fac-13/HP-game
Testing with setTimeout

Not sure if you managed to get round to it, but you can pass in done() as a callback in jest: it( mock setTimeout test , (done) = { setTimeout(() = { console.log( TIME IS UP ); done(); }, ...
  • helenzhou6
  • 6
  • Opened 
    on May 24, 2018
  • #9

fac-13/HP-game
-1 if miss hitting a mole

At this point should run this.props.decFunction - so when a mole appears and you miss it, you get deducted a point from your score https://github.com/fac-13/HP-game/blob/6236bf676bcc88461f96a1abe83198422a012593/src/components/mole/mole.js#L27 ...
  • helenzhou6
  • Opened 
    on May 24, 2018
  • #8
Issue origami icon

Learn how you can use GitHub Issues to plan and track your work.

Save views for sprints, backlogs, teams, or releases. Rank, sort, and filter issues to suit the occasion. The possibilities are endless.Learn more about GitHub Issues
ProTip! 
Press the
/
key to activate the search input again and adjust your query.
Issue origami icon

Learn how you can use GitHub Issues to plan and track your work.

Save views for sprints, backlogs, teams, or releases. Rank, sort, and filter issues to suit the occasion. The possibilities are endless.Learn more about GitHub Issues
ProTip! 
Restrict your search to the title by using the in:title qualifier.
Issue search results · GitHub