[vpdq] 0.2.2 #1654
Merged
[vpdq] 0.2.2 #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
julietshen
pushed a commit
to julietshen/tx-sandbox
that referenced
this pull request
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Lots of fixes for compiling, some bug fixes, and some refactoring.
Only real public API change is
matchTwoHashBrute()parameters were changed from value to const reference, which should not break anything.vpdq PRs diff:
Ensure VpdqHasher joins threads on destruction [vpdq] Ensure VpdqHasher joins threads on destruction #1608
Fix macOS build [vpdq] Fix macOS build #1605
Modernize CMake Usage [vpdq] Modernize CMake Usage #1600
Refactor video hashing [vpdq] Refactor video hashing #1590
Remove unused constant [vpdq] Remove unused constant #1542
Test Plan
CI is passing. If something breaks I'll fix it asap.