Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[py-tx] Migrate setup.py to pyproject.toml for modern packaging #1746
base: main
Are you sure you want to change the base?
[py-tx] Migrate setup.py to pyproject.toml for modern packaging #1746
Changes from 15 commits
ae1a6ed
60c503b
97902c3
0a281ae
5a02750
1f66227
d427439
8dddc5f
064aa37
77969dd
13d391d
06069aa
960509e
d32c9e0
97ab3c3
a3a0b82
ac85f17
59b5b9e
0b693e4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old code currently loads a long description (shown on the pypi) from DESCRIPTION.rst and README.md, will we need that for this to retain behavior with pypi?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On line 9;
readme = "README.md"
should workin the original setup.py though,
DESCRIPTION.rst
wasn't used and was just the description that shows up rn... so I thought to keep the description that was there. I think it only shows up on pypi package index - so up to you which one to use.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ended up using the rst one... as that was probably the intention
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blocking: I don't think this will correctly capture our version strings, which are in \d+.\d+.\d+ form.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, changed to
"^(?P<version>\\d+\\.\\d+\\.\\d+)$"
This file was deleted.