Faster and more complete CI #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BPF example programs are not used anymore, and are not maintained.
Remove the sudo usage from the end-to-end tests and the benchmark. The user is expected to call sudo (or other) if needed. The benchmark binary will also check for SUDO_UID and SUDO_GID environment variables to set the proper permission to the generated file.
Modify the unit tests CMake target to follow the practices used by benchmark and e2e. The LCOV tracefile will be located into $BUILD/output/tests.
Add a link in the documentation to open the benchmark and the code coverage reports generated during the build. Both reports are generated with the `make doc` command using custom scripts: - benchreport: read all the benchmark results located in the build/output/benchmarks and summarise them into a single HTML file based on a template - covreport: generate an HTML coverage report using genhtml The key point with those scripts is they allow their input files to be absent, in which case they print a warning and exist without any error.
Use Docker custom docker containers to build and test bpfilter, those containers are stored into the repo's registery and used during subsequent CI run as cache to speed up the CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the CI to speed up the build process and provide better signals during the PRs.
The whole idea is to use custom Docker containers to build the project into, those containers are built from Dockerfiles in
.githubfolder, and they're stored in the repo's registry. This allows the CI to reuse those containers as cache on the next run. Hence, while the first run (with the container creation) can be a bit slower than before the change, subsequent runs will set up the build environment in ~20 seconds instead of 1 to 2 minutes.Another notable change is the integration of the benchmarks report and the coverage report in the project's documentation.