feat(postfix): add support for ubuntu #225
Open
+21
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrichins
reviewed
Jul 21, 2023
| '127.0.0.1' => 'OK', | ||
| main_cf = value_for_platform_family( | ||
| 'debian' => { | ||
| 'compatibility_level' => '3.6', |
There was a problem hiding this comment.
Am I right in thinking we would need most of the default config as well
There was a problem hiding this comment.
I was able to send mail using the default postfix settings just fine!
PatrickDale
requested review from
jaymzh,
joshuamiller01 and
davide125
as code owners
PatrickDale
added a commit
to etsy/chef-cookbooks
that referenced
this pull request
Jul 21, 2023
## Description Cherry picks upstream changes from facebook/pull/225. ## Context / Why are we making this change? Will allow us to install and configure `postfix` on Ubuntu Jammy.
jaymzh
requested changes
Feb 2, 2025
jaymzh
requested changes
Feb 6, 2025
There was a problem hiding this comment.
Just to follow up here with a few more details.
I'm fine bumping the compatibility level - we can probably do that everywhere, frankly.
Dropping most of the default config doesn't seem appropriate, most of these configs are the defaults from main.conf.proto - similar across both Debian and Fedora. If there's problematic ones, happy to nuke them.
Just FYI I'm using this on Debian sid without an issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fb_postfixto be used on Debian families.fb_postfixmain.cfsettings for Debian families since we see errors from them.Context / Why are we making this change?
To use
fb_postfixon Ubuntu.