fb_apt: Significant updates #250
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaymzh
force-pushed
the
fb_apt_modernization
branch
from
248cd2b to
ebc93be
Compare
jaymzh
commented
Feb 3, 2025
| } | ||
| # fb_apt must be defined for this to work... | ||
| keys = FB::Apt.get_official_keyids(node).map { |id| [id, nil] }.to_h |
There was a problem hiding this comment.
this is OK because we only look at keyis in /etc/trusted.gpg now, not all keyids in /etc/trusted.gpg.d/* - as those are cleaned up separately.
* Deprecate `node['fb_apt']['repos']` which was always a bad API (sorry), and replace it with `node['fb_apt']['sources']` which integrates nicely with the new `node['fb_apt']['keymap']` * Deprecate `node['fb_apt']['keys']` which was very broken on modern apt and replace it with a new `node['fb_apt']['keymap']` * Update syntax for security and update repos on modern debian and ubuntu * Remove old Ubuntu 16 cruft * Lots of cleanups and refactoring for readability Signed-off-by: Phil Dibowitz <[email protected]>
jaymzh
force-pushed
the
fb_apt_modernization
branch
from
ebc93be to
1fe7d2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node['fb_apt']['repos']which was always a bad API(sorry), and replace it with
node['fb_apt']['sources']whichintegrates nicely with the new
node['fb_apt']['keymap']node['fb_apt']['keys']which was very broken on modernapt and replace it with a new
node['fb_apt']['keymap']ubuntu
Signed-off-by: Phil Dibowitz [email protected]