Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New cookbook: fb_nginx #71

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

New cookbook: fb_nginx #71

wants to merge 1 commit into from

Conversation

jaymzh
Copy link
Collaborator

@jaymzh jaymzh commented Sep 27, 2019

This cookbook manages Nginx using the FB attribute-driven model. It is
heavily based off of fb_apache, with a few extra nicities thrown in.

NOTE: Needs some testing on a RH-like OS before merging.

Signed-off-by: Phil Dibowitz [email protected]

cookbooks/fb_nginx/recipes/default.rb Show resolved Hide resolved
cookbooks/fb_nginx/resources/create_certs.rb Outdated Show resolved Hide resolved
cookbooks/fb_nginx/resources/create_certs.rb Outdated Show resolved Hide resolved
end

execute "create key/cert for #{site}" do
command 'openssl req -new -newkey rsa:4096 -x509 -sha256 -days 365 ' +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will fail if the openssl CLI is missing (same as stunnel)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm adding an error but not breaking the run (the run will break when the service can't start). I'm not sure which is better....

@jaymzh
Copy link
Collaborator Author

jaymzh commented Oct 3, 2019

rebased and addressed review comments.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gbatye has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@jaymzh
Copy link
Collaborator Author

jaymzh commented Jun 26, 2020

rebased and add the last month or so of fixes.

@facebook-github-bot
Copy link
Contributor

@jaymzh has updated the pull request. Re-import the pull request

@facebook-github-bot
Copy link
Contributor

@jaymzh has updated the pull request. Re-import the pull request

@facebook-github-bot
Copy link
Contributor

@jaymzh has updated the pull request. Re-import the pull request

@facebook-github-bot
Copy link
Contributor

@jaymzh has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@jaymzh has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@jaymzh has updated the pull request. You must reimport the pull request before landing.

This cookbook manages Nginx using the FB attribute-driven model. It is
heavily based off of `fb_apache`, with a few extra nicities thrown in.

NOTE: Needs some testing on a RH-like OS before merging.

Signed-off-by: Phil Dibowitz <[email protected]>
@facebook-github-bot
Copy link
Contributor

@jaymzh has updated the pull request. You must reimport the pull request before landing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants