Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brikk #12853

Open
wants to merge 2,139 commits into
base: 0.9.x
Choose a base branch
from
Open

brikk #12853

wants to merge 2,139 commits into from

Conversation

Billydee87
Copy link

mrmckeb and others added 30 commits July 29, 2020 10:25
Co-authored-by: Ian Schmitz <[email protected]>
Co-authored-by: Ian Sutherland <[email protected]>
* Added React logo in README.md

* Added React logo in README file that makes looks nicer now.

* Added CRA Logo in README.md that looks nicer

* Replacing React Logo with CRA Logo instead

Co-authored-by: Eddie Monge Jr <[email protected]>

* Update README.md

Co-authored-by: Eddie Monge Jr <[email protected]>
Co-authored-by: Dan Abramov <[email protected]>
@Billydee87
Copy link
Author

yeah

In #11318 a change was made to `babel-preset-react-app` to require `@babel/plugin-proposal-private-property-in-object`, but no such dependency was added to `package.json`. This fixes that mistake by adding the dependency.
@facebook-github-bot
Copy link

Hi @Billydee87!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

zpao and others added 18 commits June 14, 2023 13:58
Beyond just a pure migration, this also:

- Drops Node 14 usage from CI (which also removes the need for explicit
  npm 8 installs)
- Removes the "old node" test, which just checked that installing on old
  node failed. We shouldn't need to test that
- Consolidates the build & test workflows so we don't end up with
  a proliferation of workflows.
Update running-tests
Update running-tests.md
Co-authored-by: Rajhans Jadhao <[email protected]>
idk
…l-16

fix: upgrade RTL version to avoid peer-deps mismatch
…ing a message on init (#17003)

It's probably time to make this project document its status as being
deprecated and not recommended for production usage.

To change it:

- I opted to add a header to the README saying its over and you should
go look at https://react.dev/learn/start-a-new-react-project

- I left a note saying that if you are following, it is maybe worth
carrying on. While I hear react 19 doesn't work with CRA, I wouldn't be
surprised that a good chunk of tutorials would still work. Open to being
a bit more hard-lined there but there was a lot of great resources for
learning react in that era and it seems like a waste to be making people
stop early?

- I added a message inside the CLI, it shows once and says "don't use
this, use the stuff in
https://react.dev/learn/start-a-new-react-project"

---------

Co-authored-by: Ricky <[email protected]>
Co-authored-by: Rick Hanlon <[email protected]>
Updates to a shortlink that we can redirect as needed for old versions.
Currently 404
- Adds a banner with deprecation notice
- Adds a noindex meta tag to home page to remove from search
- Add og meta info for when noindex is ignored
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment