-
-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: upgrade RTL version to avoid peer-deps mismatch #13738
fix: upgrade RTL version to avoid peer-deps mismatch #13738
Conversation
|
Hi, when will this PR get accepted and merged into main branch? |
Co-authored-by: Rajhans Jadhao <[email protected]>
The remaining test failure seems legit but I'm not sure how to fix. |
Looks like the failing tests needs to be updated according to the latest React version |
hi @rickhanlonii, I think will need to use the react-testing-lib for the failing test cases just like here
Reference link - https://kentcdodds.com/blog/common-mistakes-with-react-testing-library#not-using-screen |
@iamrajhans no, these tests are not using RTL. The issue is that the webpack config for SVGs uses an old version of |
Resolves #13721
This PR upgrades the installed version of RTL to resolve the peer deps issue.
It also installs DTL because RTL version 16 requires DTL to be installed.