Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shimondoodkin error filename #17010

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Shimondoodkin error filename #17010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c82652e
Update build.js check if error message has filename, to not print sin…
shimondoodkin Jan 31, 2025
2dd7209
Update formatWebpackMessages.js - ensure message contains filename
shimondoodkin Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions packages/react-dev-utils/formatWebpackMessages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,18 +13,33 @@ function isLikelyASyntaxError(message) {
return message.indexOf(friendlySyntaxErrorLabel) !== -1;
}

function cleanTerminalColors(input) {
// Regular expression to match ANSI escape codes
const ansiRegex = /\x1B\[[0-9;]*[a-zA-Z]/g;
// Remove ANSI escape codes from the input string
return input.replace(ansiRegex, '');
}

// Cleans up webpack error messages.
function formatMessage(message) {
let lines = [];

if (typeof message === 'string') {
lines = message.split('\n');
lines = cleanTerminalColors(message).split('\n');
} else if ('message' in message) {
lines = message['message'].split('\n');
lines = cleanTerminalColors(message['message']).split('\n');
// ensure message contains filename
if ('file' in message && !message['message'].includes(message.file)) {
lines.unshift("While building top file: " + message.file);
}
} else if (Array.isArray(message)) {
message.forEach(message => {
if ('message' in message) {
lines = message['message'].split('\n');
lines = cleanTerminalColors(message['message']).split('\n');
// ensure message contains filename
if ('file' in message && !message['message'].includes(message.file)) {
lines.unshift("While building top file: " + message.file);
}
}
});
}
Expand Down
8 changes: 6 additions & 2 deletions packages/react-scripts/scripts/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,12 @@ function build(previousFileSizes) {
if (messages.errors.length) {
// Only keep the first error. Others are often indicative
// of the same problem, but confuse the reader with noise.
if (messages.errors.length > 1) {
messages.errors.length = 1;
const re = /\S+:\d+:\d+/; // check if error message has filename with line number, to not print errors with no filename or line number
for(let i = 0; i < messages.errors.length; i++) {
if(re.test(messages.errors[i])) {
messages.errors.length = i+1;
break;
}
}
return reject(new Error(messages.errors.join('\n\n')));
}
Expand Down