Skip to content

Ignore dotfiles from yarn v2 #8409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Ignore dotfiles from yarn v2 #8409

wants to merge 1 commit into from

Conversation

fifn2
Copy link

@fifn2 fifn2 commented Feb 1, 2020

Yarn version 2 makes some new cache files under .yarn. I don't think they should be commited.

@facebook-github-bot
Copy link

Hi fifn2! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@rayronvictor
Copy link

@fifn2 and what about the zero-installs feature?

@fifn2
Copy link
Author

fifn2 commented Feb 27, 2020

Oh No! I'll add them.

@ianschmitz
Copy link
Contributor

This isn't quite that simple. See https://yarnpkg.com/advanced/qa#which-files-should-be-gitignored.

I'm not sure what we'll want to do here. @arcanis any thoughts on best approach?

@ianschmitz ianschmitz added this to the 3.4.1 milestone Feb 28, 2020
@iansu iansu modified the milestones: 3.4.1, 3.4.2 Mar 20, 2020
@mungojam
Copy link

It would be amazing if all CRA dependencies didn't rely on being unplugged as that unplugged folder seems to be one of the more difficult folders to decide to include or not. I think it doesn't work for cross platform teams for example.

@ianschmitz ianschmitz modified the milestones: 3.5, 4.0 May 3, 2020
@ianschmitz
Copy link
Contributor

Thanks for the PR, but we're not going to make this change at this time. If folks are using yarn 2 in their project they can decide which to ignore depending on their setup.

@ianschmitz ianschmitz closed this May 4, 2020
@lock lock bot locked and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants