Add missing cstdint includes (#1040)

Summary: I added the missing <cstdint> includes to fix build errors when using uint*_t with clang 16. I also added .cache to gitignore so I don't acidentally commit the clangd LSP cache directory. The errors that this PR fixes look like this: ``` ^ /home/theo/dev/hermes/public/hermes/Public/../../hermes/Public/DebuggerTypes.h:40:11: error: unknown type name 'uint64_t' constexpr uint64_t kInvalidBreakpoint = 0; ``` Pull Request resolved: #1040 Reviewed By: avp Differential Revision: D47271899 Pulled By: neildhar fbshipit-source-id: 4f3bdfc1c90583fdfcbbe10c3c9cc84e7f7bb690
facebook · Jul 7, 2023 · 1c18a40 · 1c18a40
1 parent 0faaf5e
commit 1c18a40
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/.gitignore b/.gitignore
@@ -31,3 +31,6 @@ android/intltest/java/com/facebook/hermes/test/assets/**
 # VS Code and Visual Studio
 .vs
 .vscode
+
+# clangd cache
+.cache/
diff --git a/include/hermes/Support/SHA1.h b/include/hermes/Support/SHA1.h
@@ -9,6 +9,7 @@
 #define HERMES_SUPPORT_SHA1_H
 
 #include <array>
+#include <cstdint>
 #include <string>
 
 namespace hermes {

diff --git a/public/hermes/Public/DebuggerTypes.h b/public/hermes/Public/DebuggerTypes.h
@@ -8,6 +8,7 @@
 #ifndef HERMES_PUBLIC_DEBUGGERTYPES_H
 #define HERMES_PUBLIC_DEBUGGERTYPES_H
 
+#include <cstdint>
 #include <string>
 #include <vector>
 #pragma GCC diagnostic push
-Original file line number
+Diff line change
@@ Expand Up / @@ -31,3 +31,6 @@ android/intltest/java/com/facebook/hermes/test/assets/** @@
     # VS Code and Visual Studio
     .vs
     .vscode
+    # clangd cache
+    .cache/