Use TARGET_OS_TV definition from TargetConditionals.h

Summary:
Instead of defining the OS preprocessor flags ourselves in CMake,
import TargetConditionals.h which will define them.

Reviewed By: tmikov

Differential Revision: D64090935

fbshipit-source-id: 8f0bc4f1947a400b657caca10ac3cc81bf839c6e

CMakeLists.txt

@@ -57,11 +57,6 @@ if(HERMES_APPLE_TARGET_PLATFORM MATCHES "catalyst")
   set(THREADS_PREFER_PTHREAD_FLAG ON)
 endif()
 
-if(HERMES_APPLE_TARGET_PLATFORM MATCHES "appletv")
-  add_definitions(-DTARGET_OS_IPHONE=1)
-  add_definitions(-DTARGET_OS_TV=1)
-endif()
-
 # This must be consistent with the release_version in:
 # - android/build.gradle
 # - npm/package.json

external/llvh/lib/Support/Unix/Process.inc

@@ -51,6 +51,9 @@
 #ifdef HAVE_TERMIOS_H
 #  include <termios.h>
 #endif
+#if defined(__APPLE__)
+#include <TargetConditionals.h>
+#endif
 
 //===----------------------------------------------------------------------===//
 //=== WARNING: Implementation here must contain only generic UNIX code that

external/llvh/lib/Support/Unix/Program.inc

@@ -40,12 +40,11 @@
 #if HAVE_UNISTD_H
 #include <unistd.h>
 #endif
-#ifdef HAVE_POSIX_SPAWN
-#include <spawn.h>
-
 #if defined(__APPLE__)
 #include <TargetConditionals.h>
 #endif
+#ifdef HAVE_POSIX_SPAWN
+#include <spawn.h>
 
 #if defined(__APPLE__) && !(defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE)
 #define USE_NSGETENVIRON 1

lib/Support/OSCompatPosix.cpp

@@ -63,6 +63,10 @@
 #endif
 #endif // __ANDROID__
 
+#ifdef __APPLE__
+#include <TargetConditionals.h>
+#endif
+
 #include "llvh/Support/raw_ostream.h"
 
 namespace hermes {