Skip to content

Remove [[fallthough]] replacement in generated header perfect hash #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −5
Open

Remove [[fallthough]] replacement in generated header perfect hash #558

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions proxygen/lib/utils/gen_perfect_hash_table.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,6 @@ function generate_perfect_hash_table {
LC_ALL=C sort -u ${1?} | awk "${3?}" - "${2?}" > "${4?}"

# Generate output source file.
# We also sub out the default 'FALLTHROUGH' comment statements as modern
# compilers will raise warnings unless the fallthrough is explicit.
LC_ALL=C sort -u ${1?} | awk "${6?}" - "${5?}" | \
${8:-gperf} -m5 -D --output-file="${7?}"
perl -p -i -e "s/\/\*FALLTHROUGH\*\//[[fallthrough]];/g" "${7?}"

# Here we delete one of the comment lines gperf adds to the top of the file.
# i.e. /* Command-line: .../gperf -m5 --output-file=... */
Expand Down
Loading