Skip to content

fix VScode extension does not highlight problems in files with symlinked paths under linux #1104 #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

fix VScode extension does not highlight problems in files with symlinked paths under linux #1104 #1387

wants to merge 3 commits into from

Conversation

@asukaminato0721
Copy link
Contributor

@asukaminato0721 asukaminato0721 commented Oct 25, 2025 •
edited
Loading

fix #1104

image

@meta-cla meta-cla bot added the cla signed label Oct 25, 2025
@asukaminato0721 asukaminato0721 marked this pull request as ready for review October 25, 2025 13:24
@samwgoldman
Copy link
Member

Please add an automated test. Why does this change fix the issue? Is it because canonicalize invokes realpath and absolutize doesn’t?

@meta-codesync
Copy link

meta-codesync bot commented Oct 29, 2025

@kinto0 has imported this pull request. If you are a Meta employee, you can view this in D85790344.

@kinto0
Copy link
Contributor

kinto0 commented Oct 29, 2025

Please add an automated test. Why does this change fix the issue? Is it because canonicalize invokes realpath and absolutize doesn’t?

I just tested it before/after and it seems to fix it well. yeah, canonicalize actually looks on the file system and resolves symlinks while absolutize does not.

grievejia
grievejia approved these changes Oct 30, 2025
View reviewed changes
Copy link
Contributor

@grievejia grievejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@meta-codesync meta-codesync bot closed this in 8549730 Oct 30, 2025
@meta-codesync
Copy link

meta-codesync bot commented Oct 30, 2025

@kinto0 merged this pull request in 8549730.

@asukaminato0721 asukaminato0721 deleted the 1104 branch October 31, 2025 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grievejia grievejia grievejia approved these changes

Assignees

No one assigned

Labels

cla signed Merged needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

VScode extension does not highlight problems in files with symlinked paths under linux

5 participants

@asukaminato0721 @samwgoldman @kinto0 @grievejia @facebook-github-bot