Isolate NativeDevSettings load #52821
Closed
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: While adding an opt native/dev js mode to fantom, LogBox was trying to load NativeDevSettings when it didn't exist because of mode mismatch. This is the only location it's happening, so this just moved the NativeDevSettings load into the one function that needs it, probably not the best solution because if this function gets called in this mode we will crash still, but it works for now. Changelog: [Internal] Differential Revision: D78952284
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78952284 |
sbuggay
added a commit
to sbuggay/react-native
that referenced
this pull request
Jul 25, 2025
Summary: While adding an opt native/dev js mode to fantom, LogBox was trying to load NativeDevSettings when it didn't exist because of mode mismatch. This is the only location it's happening, so this just moved the NativeDevSettings load into the one function that needs it, probably not the best solution because if this function gets called in this mode we will crash still, but it works for now. Changelog: [Internal] Differential Revision: D78952284
sbuggay
added a commit
to sbuggay/react-native
that referenced
this pull request
Jul 25, 2025
Summary: While adding an opt native/dev js mode to fantom, LogBox was trying to load NativeDevSettings when it didn't exist because of mode mismatch. This is the only location it's happening, so this just moved the NativeDevSettings load into the one function that needs it, probably not the best solution because if this function gets called in this mode we will crash still, but it works for now. Changelog: [Internal] Differential Revision: D78952284
sbuggay
added a commit
to sbuggay/react-native
that referenced
this pull request
Jul 28, 2025
Summary: Hardens RN to running in mismatched opt/dev modes. While adding an opt native/dev js mode to fantom, LogBox was trying to load NativeDevSettings when it didn't exist because of mode mismatch. This is the only location it's happening, so this just moves the NativeDevSettings load into the one function that needs it. Changelog: [Internal] Differential Revision: D78952284
sbuggay
added a commit
to sbuggay/react-native
that referenced
this pull request
Jul 29, 2025
Summary: Hardens RN to running in mismatched opt/dev modes. While adding an opt native/dev js mode to fantom, LogBox was trying to load NativeDevSettings when it didn't exist because of mode mismatch. This is the only location it's happening, so this just moves the NativeDevSettings load into the one function that needs it. Changelog: [Internal] Reviewed By: rubennorte Differential Revision: D78952284
sbuggay
added a commit
to sbuggay/react-native
that referenced
this pull request
Jul 30, 2025
Summary: Hardens RN to running in mismatched opt/dev modes. While adding an opt native/dev js mode to fantom, LogBox was trying to load NativeDevSettings when it didn't exist because of mode mismatch. This is the only location it's happening, so this just moves the NativeDevSettings load into the one function that needs it. Changelog: [Internal] Reviewed By: rubennorte Differential Revision: D78952284
sbuggay
added a commit
to sbuggay/react-native
that referenced
this pull request
Jul 30, 2025
Summary: Hardens RN to running in mismatched opt/dev modes. While adding an opt native/dev js mode to fantom, LogBox was trying to load NativeDevSettings when it didn't exist because of mode mismatch. This is the only location it's happening, so this just moves the NativeDevSettings load into the one function that needs it. Changelog: [Internal] Reviewed By: rubennorte Differential Revision: D78952284
|
This pull request was successfully merged by @sbuggay in 807f0b6 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
While adding an opt native/dev js mode to fantom, LogBox was trying to load NativeDevSettings when it didn't exist because of mode mismatch.
This is the only location it's happening, so this just moved the NativeDevSettings load into the one function that needs it, probably not the best solution because if this function gets called in this mode we will crash still, but it works for now.
Changelog: [Internal]
Differential Revision: D78952284