Add Error creation APIs for all standard JS error types (#56159)#56159
Closed
tsaichien wants to merge 6 commits into
Closed
Add Error creation APIs for all standard JS error types (#56159)#56159tsaichien wants to merge 6 commits into
tsaichien wants to merge 6 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@tsaichien has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95854323. |
meta-codesync
Bot
changed the title
tsaichien
force-pushed
the
export-D95854323
branch
from
8557fe0 to
127e49e
Compare
tsaichien
added a commit
to tsaichien/react-native
that referenced
this pull request
Mar 19, 2026
Summary: Pull Request resolved: facebook#56159 Add Error creation APIs to JSI to allow native code to create JavaScript Error objects of all standard types. Users can also call the static methods in `JSError` that creates a `JSError` instance that holds the intended error type. Changelog: [Internal] Reviewed By: lavenzg Differential Revision: D95854323
tsaichien
force-pushed
the
export-D95854323
branch
from
127e49e to
3a6da2c
Compare
tsaichien
added a commit
to tsaichien/react-native
that referenced
this pull request
Mar 30, 2026
Summary: Pull Request resolved: facebook#56159 Add Error creation APIs to JSI to allow native code to create JavaScript Error objects of all standard types. Users can also call the static methods in `JSError` that creates a `JSError` instance that holds the intended error type. Changelog: [Internal] Reviewed By: lavenzg Differential Revision: D95854323
tsaichien
force-pushed
the
export-D95854323
branch
from
3a6da2c to
621185b
Compare
tsaichien
added a commit
to tsaichien/react-native
that referenced
this pull request
Mar 31, 2026
Summary: Pull Request resolved: facebook#56159 Add Error creation APIs to JSI to allow native code to create JavaScript Error objects of all standard types. Users can also call the static methods in `JSError` that creates a `JSError` instance that holds the intended error type. Changelog: [Internal] Reviewed By: lavenzg Differential Revision: D95854323
tsaichien
force-pushed
the
export-D95854323
branch
from
621185b to
51e1939
Compare
tsaichien
added a commit
to tsaichien/react-native
that referenced
this pull request
Apr 14, 2026
Summary: Pull Request resolved: facebook#56159 Add Error creation APIs to JSI to allow native code to create JavaScript Error objects of all standard types. Users can also call the static methods in `JSError` that creates a `JSError` instance that holds the intended error type. Changelog: [Internal] Reviewed By: lavenzg Differential Revision: D95854323
tsaichien
force-pushed
the
export-D95854323
branch
from
51e1939 to
5bf9e4e
Compare
tsaichien
added a commit
to tsaichien/react-native
that referenced
this pull request
Apr 14, 2026
Summary: Pull Request resolved: facebook#56159 Add Error creation APIs to JSI to allow native code to create JavaScript Error objects of all standard types. Users can also call the static methods in `JSError` that creates a `JSError` instance that holds the intended error type. Changelog: [Internal] Reviewed By: lavenzg Differential Revision: D95854323
tsaichien
force-pushed
the
export-D95854323
branch
from
5bf9e4e to
7fec0c1
Compare
Summary: After reviewing the feasibility of adding new Runtime functionality, we realized the current state of `Runtime` makes it hard/inconvenient to add new basic functionality. It requires creating a new interface (e.g. `IRuntime2`) to declare the new APIs. Then, everywhere it is needed, both the original `Runtime` and `IRuntime2` needs to passed in to access both APIs. After discussion, we decided to introduce `IRuntime`, which will declare most of the `Runtime` functionalities. All "protected" APIs, which made sense before interfaces were introduced, will now be public. The protected static methods of `Runtime` will remain as is for the Friends to access. After we decided to cut "stable" (after incoming JSI improvements), new functionalities will be added in `IRuntime2` interface. `IRuntime2` will inherit `IRuntime` to make existing functionality easy to access. Differential Revision: D89093651
Summary: Currently, the size of a jsi `Array` is immutable. Once the `Array` is created, users can only set the element at an existing index, but not append to it. This change adds an `Array::push` API to improve ergonomics. Differential Revision: D82254334
Summary: Adds `ArrayBuffer::getMutableBuffer` to JSI. This allows the user to retrieve a `MutableBuffer` from the `ArrayBuffer`. The data referenced by the `MutableBuffer` will be alive during the entirety of the `MutableBuffer` lifespan. Addresses: facebook/hermes#1578 Differential Revision: D91264901
Differential Revision: D92993088
Summary: Add TypedArray and Uint8Array types to JSI with supporting APIs. New types: - `TypedArray`: Base class for all typed arrays - `Uint8Array`: Uint8Array type extending TypedArray New IRuntime APIs: - `buffer(TypedArray)`: Get underlying ArrayBuffer - `byteOffset(TypedArray)`: Get byte offset property - `byteLength(TypedArray)`: Get byte length property - `length(TypedArray)`: Get length property - `createUint8Array(size_t)`: Create Uint8Array with length - `createUint8Array(ArrayBuffer, offset, length)`: Create from ArrayBuffer - `isUint8Array(Object)`: Check if object is Uint8Array Differential Revision: D95245175
Summary: Pull Request resolved: facebook#56159 Add Error creation APIs to JSI to allow native code to create JavaScript Error objects of all standard types. Users can also call the static methods in `JSError` that creates a `JSError` instance that holds the intended error type. Changelog: [Internal] Reviewed By: lavenzg Differential Revision: D95854323
tsaichien
force-pushed
the
export-D95854323
branch
from
7fec0c1 to
47b62d1
Compare
meta-codesync Bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Apr 15, 2026
Summary: X-link: facebook/react-native#56159 Add Error creation APIs to JSI to allow native code to create JavaScript Error objects of all standard types. Users can also call the static methods in `JSError` that creates a `JSError` instance that holds the intended error type. Changelog: [Internal] Reviewed By: lavenzg Differential Revision: D95854323 fbshipit-source-id: ec473caad527bfd6c92b1ef2562b8bf41942dd5a
meta-codesync Bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Apr 15, 2026
Summary: X-link: facebook/react-native#56159 Add Error creation APIs to JSI to allow native code to create JavaScript Error objects of all standard types. Users can also call the static methods in `JSError` that creates a `JSError` instance that holds the intended error type. Changelog: [Internal] Reviewed By: lavenzg Differential Revision: D95854323 fbshipit-source-id: ec473caad527bfd6c92b1ef2562b8bf41942dd5a
meta-codesync Bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Apr 15, 2026
Summary: X-link: facebook/react-native#56159 Add Error creation APIs to JSI to allow native code to create JavaScript Error objects of all standard types. Users can also call the static methods in `JSError` that creates a `JSError` instance that holds the intended error type. Changelog: [Internal] Reviewed By: lavenzg Differential Revision: D95854323 fbshipit-source-id: ec473caad527bfd6c92b1ef2562b8bf41942dd5a
|
This pull request has been merged in 82984b4. |
tsaichien
added a commit
to tsaichien/hermes
that referenced
this pull request
Apr 15, 2026
Summary: X-link: facebook/react-native#56159 Add Error creation APIs to JSI to allow native code to create JavaScript Error objects of all standard types. Users can also call the static methods in `JSError` that creates a `JSError` instance that holds the intended error type. Changelog: [Internal] Reviewed By: lavenzg Differential Revision: D95854323 fbshipit-source-id: ec473caad527bfd6c92b1ef2562b8bf41942dd5a
tsaichien
added a commit
to tsaichien/hermes
that referenced
this pull request
Apr 15, 2026
Summary: X-link: facebook/react-native#56159 Add Error creation APIs to JSI to allow native code to create JavaScript Error objects of all standard types. Users can also call the static methods in `JSError` that creates a `JSError` instance that holds the intended error type. Changelog: [Internal] Reviewed By: lavenzg Differential Revision: D95854323 fbshipit-source-id: ec473caad527bfd6c92b1ef2562b8bf41942dd5a
tsaichien
added a commit
to tsaichien/hermes
that referenced
this pull request
Apr 15, 2026
Summary: X-link: facebook/react-native#56159 Add Error creation APIs to JSI to allow native code to create JavaScript Error objects of all standard types. Users can also call the static methods in `JSError` that creates a `JSError` instance that holds the intended error type. Changelog: [Internal] Reviewed By: lavenzg Differential Revision: D95854323 fbshipit-source-id: ec473caad527bfd6c92b1ef2562b8bf41942dd5a
tsaichien
added a commit
to tsaichien/hermes
that referenced
this pull request
Apr 15, 2026
Summary: X-link: facebook/react-native#56159 Add Error creation APIs to JSI to allow native code to create JavaScript Error objects of all standard types. Users can also call the static methods in `JSError` that creates a `JSError` instance that holds the intended error type. Changelog: [Internal] Reviewed By: lavenzg Differential Revision: D95854323 fbshipit-source-id: ec473caad527bfd6c92b1ef2562b8bf41942dd5a
tsaichien
added a commit
to tsaichien/hermes
that referenced
this pull request
Apr 16, 2026
Summary: X-link: facebook/react-native#56159 Add Error creation APIs to JSI to allow native code to create JavaScript Error objects of all standard types. Users can also call the static methods in `JSError` that creates a `JSError` instance that holds the intended error type. Changelog: [Internal] Reviewed By: lavenzg Differential Revision: D95854323 fbshipit-source-id: ec473caad527bfd6c92b1ef2562b8bf41942dd5a
tsaichien
added a commit
to tsaichien/hermes
that referenced
this pull request
Apr 16, 2026
Summary: X-link: facebook/react-native#56159 Add Error creation APIs to JSI to allow native code to create JavaScript Error objects of all standard types. Users can also call the static methods in `JSError` that creates a `JSError` instance that holds the intended error type. Changelog: [Internal] Reviewed By: lavenzg Differential Revision: D95854323 fbshipit-source-id: ec473caad527bfd6c92b1ef2562b8bf41942dd5a
tsaichien
added a commit
to facebook/hermes
that referenced
this pull request
Apr 16, 2026
Summary: X-link: facebook/react-native#56159 Add Error creation APIs to JSI to allow native code to create JavaScript Error objects of all standard types. Users can also call the static methods in `JSError` that creates a `JSError` instance that holds the intended error type. Changelog: [Internal] Reviewed By: lavenzg Differential Revision: D95854323 fbshipit-source-id: ec473caad527bfd6c92b1ef2562b8bf41942dd5a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add Error creation APIs to JSI to allow native code to create JavaScript
Error objects of all standard types.
Users can also call the static methods in
JSErrorthat creates aJSErrorinstance that holds the intended error type.Changelog: [Internal]
Reviewed By: lavenzg
Differential Revision: D95854323