Fix stuck loading banner after a reload#56452
Closed
alanjhughes wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
alanjhughes
changed the title
facebook-github-tools
Bot
added
the
Shared with Meta
huntie
approved these changes
Apr 15, 2026
|
@huntie has imported this pull request. If you are a Meta employee, you can view this in D101004084. |
Collaborator
|
This pull request was successfully merged by @alanjhughes in e122c24 When will my fix make it into a release? | How to file a pick request? |
react-native-bot
pushed a commit
that referenced
this pull request
Apr 15, 2026
Summary: Fixes an issue on iOS where the "Loading from Metro..." banner can remain stuck on screen after a reload. `RCTInstance._loadScriptFromSource` posts `RCTInstanceDidLoadBundle`, not `RCTJavaScriptDidLoadNotification`. The legacy notification is never posted, so the existing native hide path is dead. Also, `RCTDevLoadingView` has no cleanup. Without hiding the window and clearing it's reference, it remains alive and stuck on screen. ## Changelog: [IOS] [FIXED] - Fix "Loading from Metro..." banner getting stuck after reloads in quick succession. Pull Request resolved: #56452 Test Plan: 1. Launch an app on iOS 2. Trigger a reload while the "Loading from Metro..." banner is still visible. Bundle cache should be empty so it takes some time. 3. Immediately trigger a second reload while the banner is visible 4. Confirm: banner is gone once the new bundle finishes loading (previously it would remain stuck indefinitely) Reviewed By: emily8rown Differential Revision: D101004084 Pulled By: huntie fbshipit-source-id: de6446a522f80c5a8a0953303fb03fa65c6b698b
Collaborator
|
This pull request was successfully merged by @alanjhughes in 7445af3 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes an issue on iOS where the "Loading from Metro..." banner can remain stuck on screen after a reload.
RCTInstance._loadScriptFromSourcepostsRCTInstanceDidLoadBundle, notRCTJavaScriptDidLoadNotification. The legacy notification is never posted, so the existing native hide path is dead.Also,
RCTDevLoadingViewhas no cleanup. Without hiding the window and clearing it's reference, it remains alive and stuck on screen.Changelog:
[IOS] [FIXED] - Fix "Loading from Metro..." banner getting stuck after reloads in quick succession.
Test Plan: