Use tree-sitter for feature flag default rewriting (#56555)#56555
Closed
motiz88 wants to merge 1 commit into
Closed
Use tree-sitter for feature flag default rewriting (#56555)#56555motiz88 wants to merge 1 commit into
motiz88 wants to merge 1 commit into
Conversation
|
@motiz88 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101629456. |
Summary: Replaces the regex-based core of the Buck RN C++ feature flag override mechanism (D101484355) with a `tree-sitter` parser for sustainability. Changelog: [Internal] Reviewed By: robhogan Differential Revision: D101629456
8558a59 to
d40b6b5
Compare
Collaborator
|
This pull request was successfully merged by @motiz88 in 9140ff9 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 9140ff9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Replaces the regex-based core of the Buck RN C++ feature flag override mechanism (D101484355) with a
tree-sitterparser for sustainability.Changelog: [Internal]
Reviewed By: robhogan
Differential Revision: D101629456