Suppress DEPRECATION warning in NetworkEventUtilTest#56971
Closed
javache wants to merge 1 commit into
Closed
Conversation
Summary: The OSS build runs Kotlin with `-Werror`, and the test calls the now-deprecated overload `RequestBody.create(MediaType?, String)`. The file already suppresses `DEPRECATION_ERROR` for the same OkHttp-version skew; extend the existing `Silvochka:Suppress` to also cover the warning-level `DEPRECATION` so the build stops failing. ## Changelog: [Internal] Differential Revision: D106364355
meta-cla
Bot
added
the
CLA Signed
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D106364355. |
cortinico
approved these changes
May 26, 2026
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
This pull request has been merged in 5f080c5. |
Collaborator
|
This pull request was successfully merged by @javache in 5f080c5 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The OSS build runs Kotlin with
-Werror, and the test calls the now-deprecated overloadRequestBody.create(MediaType?, String). The file already suppressesDEPRECATION_ERRORfor the same OkHttp-version skew; extend the existingSilvochka:Suppressto also cover the warning-levelDEPRECATIONso the build stops failing.Changelog:
[Internal]
Differential Revision: D106364355