Fix secure Android TextInput same-text updates#57013
Conversation
|
Hi @sorinc03! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary:
Fixes #53696.
Android secure
TextInputhas a guard that skips replacing text when JS echoes the same content, preserving Android's transient password reveal timer. During the Kotlin conversion, this guard changed fromTextUtils.equals(...)to equality between the currentEditableand incomingSpannedtext. Those can contain the same characters without comparing equal, so state updates re-apply the text immediately and hide the latest revealed password character.This restores content-based equality for secure text updates and adds a regression test that same-text secure updates do not replace the existing
Editable.Changelog:
[ANDROID] [FIXED] - Preserve secure TextInput password character reveal timing when JS state echoes the same text.
Test Plan:
./gradlew :packages:react-native:ReactAndroid:testDebugUnitTest --tests com.facebook.react.views.textinput.ReactTextInputPropertyTest -Preact.internal.useHermesStable=true./gradlew :packages:react-native:ReactAndroid:ktfmtCheck -Preact.internal.useHermesStable=true