Consistently name argument, unbreak Android OSS build#57063
Open
robhogan wants to merge 1 commit into
Open
Conversation
Summary: 57eb56f broke Android OSS due to a variable rename that I missed in a rebase. Eg: https://github.com/facebook/react-native/actions/runs/26894263379/job/79328683517 ``` e: warnings found and -Werror specified w: file:///__w/react-native/react-native/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/devsupport/MultipartStreamReaderTest.kt:203:15 The corresponding parameter in the supertype 'CallCountTrackingChunkCallback' is named 'isLastChunk'. This may cause problems when calling this function with named arguments. > Task :packages:react-native:ReactAndroid:compileDebugOptimizedUnitTestKotlin > Task :packages:react-native:ReactAndroid:compileDebugOptimizedUnitTestKotlin FAILED > Task :react-native_popup-menu-android:extractReleaseAnnotations e: warnings found and -Werror specified ``` Changelog: Internal Differential Revision: D107397221
meta-cla
Bot
added
the
CLA Signed
|
@robhogan has exported this pull request. If you are a Meta employee, you can view the originating Diff in D107397221. |
cortinico
approved these changes
Jun 3, 2026
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
57eb56f broke Android OSS due to a variable rename that I missed in a rebase.
Eg:
https://github.com/facebook/react-native/actions/runs/26894263379/job/79328683517
Changelog: Internal
Differential Revision: D107397221