Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move from importAssertions to importAttributes #28952

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kentcdodds
Copy link

Summary

This is to account for the change in the proposal: https://github.com/tc39/proposal-import-attributes

Without this, you'll get the following warning on recent versions of node:

(node:39166) ExperimentalWarning: Use `importAttributes` instead of `importAssertions`

How did you test this change?

Did a find/replace and ran the tests. I also use the react-server-dom-esm node loader in a workshop with Node v20.10.0 and this change removed the warning while preserving the functionality. I did not test the other packages.

@react-sizebot
Copy link

Comparing: 190cc99...8c68a19

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB = 1.82 kB 1.82 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB = 1.83 kB 1.83 kB
facebook-www/ReactDOM-prod.classic.js = 591.11 kB 591.11 kB = 103.94 kB 103.94 kB
facebook-www/ReactDOM-prod.modern.js = 567.33 kB 567.33 kB = 100.34 kB 100.34 kB
test_utils/ReactAllWarnings.js Deleted 64.26 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.26 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Generated by 🚫 dangerJS against 8c68a19

Copy link

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@github-actions github-actions bot added the Resolution: Stale Automatically closed due to inactivity label Jul 28, 2024
@kentcdodds
Copy link
Author

It's not very important, but it's also very simple. A merge would be appreciated!

@github-actions github-actions bot removed the Resolution: Stale Automatically closed due to inactivity label Jul 28, 2024
Copy link

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@github-actions github-actions bot added the Resolution: Stale Automatically closed due to inactivity label Oct 26, 2024
@kentcdodds
Copy link
Author

Still would be nice

@github-actions github-actions bot removed the Resolution: Stale Automatically closed due to inactivity label Oct 26, 2024
@eps1lon
Copy link
Collaborator

eps1lon commented Oct 26, 2024

Do both properties have the same support matrix? If not, how can we detect which one to choose?

@kentcdodds
Copy link
Author

I do not know what the support matrix of these properties is, but considering it's still an experimental feature anyway, switching to the latest without concern for previous experimental versions seems reasonable.

@eps1lon eps1lon requested a review from sebmarkbage October 28, 2024 18:57
Copy link

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@github-actions github-actions bot added the Resolution: Stale Automatically closed due to inactivity label Jan 26, 2025
@kentcdodds
Copy link
Author

Still think this would be good to get in.

@github-actions github-actions bot removed the Resolution: Stale Automatically closed due to inactivity label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants