-
Notifications
You must be signed in to change notification settings - Fork 47.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move from importAssertions
to importAttributes
#28952
base: main
Are you sure you want to change the base?
Conversation
This is to account for the change in the proposal: https://github.com/tc39/proposal-import-attributes
Comparing: 190cc99...8c68a19 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
It's not very important, but it's also very simple. A merge would be appreciated! |
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
Still would be nice |
Do both properties have the same support matrix? If not, how can we detect which one to choose? |
I do not know what the support matrix of these properties is, but considering it's still an experimental feature anyway, switching to the latest without concern for previous experimental versions seems reasonable. |
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
Still think this would be good to get in. |
Summary
This is to account for the change in the proposal: https://github.com/tc39/proposal-import-attributes
Without this, you'll get the following warning on recent versions of node:
How did you test this change?
Did a find/replace and ran the tests. I also use the
react-server-dom-esm
node loader in a workshop with Node v20.10.0 and this change removed the warning while preserving the functionality. I did not test the other packages.