Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compiler] Created useEmailValidator.tsx. #32229

Closed
wants to merge 2 commits into from

Conversation

AhmadRazaKhokhar1
Copy link

This hook [ useEmailValidator ], will make the form validation more easier and will reduce the need of installing any third party library.

@facebook-github-bot
Copy link

Hi @AhmadRazaKhokhar1!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@eps1lon eps1lon changed the title Created useEmailValidator.tsx. [compiler] Created useEmailValidator.tsx. Jan 27, 2025
@Ahmwajih
Copy link

const strictEmailRegex = /^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+.[a-zA-Z]{2,}$/;

// Hook
export const useEmailValidator = (email: string) => {
// Error State
let errorMsg = "";

if (!email) {
errorMsg = "Email is required field";
} else if (!email.includes("@")) {
errorMsg = "'@' is missing from the email";
} else if (!email.includes(".")) {
errorMsg = "'.' is missing from the email";
} else if (!strictEmailRegex.test(email)) {
errorMsg = "Please enter a valid email";
}

// Final output
return errorMsg;
};

why you check every missing char ?, you can just check the whole email and return only "Please enter a valid email"

you can use Yup is very good
const validationSchema = yup.object({

email: yup
  .string()      
  .email("Please enter a valid email")
  .required("eMail is required")
  .test("is-valid", (message) => `${message.path} is invalid`, (value) => value ? isEmailValidator(value) : new yup.ValidationError("Invalid value")),

});

@henriquemarioto
Copy link

henriquemarioto commented Jan 27, 2025

why you check every missing char ?, you can just check the whole email and return only "Please enter a valid email"

you can use Yup is very good const validationSchema = yup.object({

@Ahmwajih I believe the idea of ​​this hook is to not use external libraries.

@poteto poteto closed this Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants