[compiler] clean up retry pipeline: fireRetry flag -> compileMode
#32511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
mofeiZ
commented
Mar 13, 2025
Comment on lines
+207
to
+209
| if (env.config.validateNoCapitalizedCalls) { | ||
| validateNoCapitalizedCalls(hir); | ||
| } |
There was a problem hiding this comment.
Reordering validateNoCapitalizedCalls and transformFire should be safe
Comment on lines
106
to
108
| ): { | ||
| fnEffectErrors: Array<CompilerErrorDetailOptions>; | ||
| } { |
There was a problem hiding this comment.
nit: just return the Array?
There was a problem hiding this comment.
or maybe Result<void, Array<CompilerErrorDetailOptions>>
josephsavona
approved these changes
Mar 13, 2025
mofeiZ
commented
Mar 13, 2025
Comment on lines
+420
to
+430
|
|
||
| if (compileResult.kind === 'error') { | ||
| /** | ||
| * If an opt out directive is present, log only instead of throwing and don't mark as | ||
| * containing a critical error. | ||
| */ | ||
| if (optOutDirectives.length > 0) { | ||
| logError(compileResult.error, pass, fn.node.loc ?? null); | ||
| } else { | ||
| handleError(compileResult.error, pass, fn.node.loc ?? null); | ||
| } |
There was a problem hiding this comment.
Moved this up as we want to report / log errors before retrying for (1) panicThreshold: 'all' | 'critical_error' modes and (2) to avoid overwriting bailout logging for non-Fire functions.
Removes `EnvironmentConfig.enableMinimalTransformsForRetry` in favor of `run` parameters. This is a minimal difference but lets us explicitly opt out certain compiler passes based on mode parameters, instead of environment configurations Retry flags don't really make sense to have in `EnvironmentConfig` anyways as the config is user-facing API, while retrying is a compiler implementation detail. (per @josephsavona's feedback #32164 (comment)) > Re the "hacky" framing of this in the PR title: I think this is fine. I can see having something like a compilation or output mode that we use when running the pipeline. Rather than changing environment settings when we re-run, various passes could take effect based on the combination of the mode + env flags. The modes might be: > > * Full: transform, validate, memoize. This is the default today. > * Transform: Along the lines of the backup mode in this PR. Only applies transforms that do not require following the rules of React, like `fire()`. > * Validate: This could be used for ESLint.
github-actions bot
pushed a commit
that referenced
this pull request
Mar 14, 2025
…32511) Removes `EnvironmentConfig.enableMinimalTransformsForRetry` in favor of `run` parameters. This is a minimal difference but lets us explicitly opt out certain compiler passes based on mode parameters, instead of environment configurations Retry flags don't really make sense to have in `EnvironmentConfig` anyways as the config is user-facing API, while retrying is a compiler implementation detail. (per @josephsavona's feedback #32164 (comment)) > Re the "hacky" framing of this in the PR title: I think this is fine. I can see having something like a compilation or output mode that we use when running the pipeline. Rather than changing environment settings when we re-run, various passes could take effect based on the combination of the mode + env flags. The modes might be: > > * Full: transform, validate, memoize. This is the default today. > * Transform: Along the lines of the backup mode in this PR. Only applies transforms that do not require following the rules of React, like `fire()`. > * Validate: This could be used for ESLint. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32511). * #32512 * __->__ #32511 DiffTrain build for [7939d92](7939d92)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
EnvironmentConfig.enableMinimalTransformsForRetryin favor ofrunparameters. This is a minimal difference but lets us explicitly opt out certain compiler passes based on mode parameters, instead of environment configurationsRetry flags don't really make sense to have in
EnvironmentConfiganyways as the config is user-facing API, while retrying is a compiler implementation detail.(per @josephsavona's feedback #32164 (comment))
Stack created with Sapling. Best reviewed with ReviewStack.
fireRetryflag -> compileMode #32511