[Fiber] Support AsyncIterable children in SuspenseList #33299
Merged
+306
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
sebmarkbage
commented
May 18, 2025
| ) { | ||
| // TODO: Technically we should warn for nested arrays inside the | ||
| // async iterable but it would require unwrapping the array. | ||
| // However, this mistake is not as easy to make so it's ok not to warn. |
There was a problem hiding this comment.
It can be costly to iterate this twice so we avoid it.
Ideally, we'd probably move the validateSuspenseListChildren warning to be integrated with the rest ChildFiber instead so that it can be done in a single pass. Even for sync iterators.
|
Comparing: 462d08f...504a75a Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
sebmarkbage
commented
May 18, 2025
| validateTailOptions(tailMode, revealOrder); | ||
| validateSuspenseListChildren(newChildren, revealOrder); | ||
|
|
||
| reconcileChildren(current, workInProgress, newChildren, renderLanes); |
There was a problem hiding this comment.
reconcileChildren can suspend which lead to the SuspenseListContext to be unbalanced so it needs to push first.
sebmarkbage
commented
May 18, 2025
| function Foo() { | ||
| return ( | ||
| <SuspenseList revealOrder="forwards"> | ||
| <Generator /> |
There was a problem hiding this comment.
This pattern would be very convenient but we can't support it since we need to resolve the rows first.
Interestingly this pattern is supported in Server Components because they get resolved into the iterable on the server and the component wrapper disappears. It's just not supported in Client Components.
sebmarkbage
force-pushed
the
suspenselistasynciterator
branch
from
36c245f to
504a75a
Compare
gnoff
approved these changes
May 20, 2025
github-actions bot
pushed a commit
that referenced
this pull request
May 20, 2025
We support AsyncIterable (more so when it's a cached form like in coming from Flight) as children. This fixes some warnings and bugs when passed to SuspenseList. Ideally SuspenseList with `tail="hidden"` should support unblocking before the full result has resolved but that's an optimization on top. We also might want to change semantics for this for `revealOrder="backwards"` so it becomes possible to stream items in reverse order. DiffTrain build for [4c6967b](4c6967b)
github-actions bot
pushed a commit
that referenced
this pull request
May 20, 2025
We support AsyncIterable (more so when it's a cached form like in coming from Flight) as children. This fixes some warnings and bugs when passed to SuspenseList. Ideally SuspenseList with `tail="hidden"` should support unblocking before the full result has resolved but that's an optimization on top. We also might want to change semantics for this for `revealOrder="backwards"` so it becomes possible to stream items in reverse order. DiffTrain build for [4c6967b](4c6967b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We support AsyncIterable (more so when it's a cached form like in coming from Flight) as children.
This fixes some warnings and bugs when passed to SuspenseList.
Ideally SuspenseList with
tail="hidden"should support unblocking before the full result has resolved but that's an optimization on top. We also might want to change semantics for this forrevealOrder="backwards"so it becomes possible to stream items in reverse order.