Skip to content

Fix region Type confusion through parameter tampering #33301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

odaysec
Copy link

@odaysec odaysec commented May 18, 2025

ignoreList: requestedFilePath.includes('node_modules')

To fix the issue, we need to ensure that req.query.name is explicitly validated to be a string before it is used. If it is not a string, the code should handle the case appropriately, such as returning an error response. This can be achieved by adding a type check for req.query.name and rejecting the request if it is not a string.

The changes will be made in the /source-maps route handler:

  1. Add a type check for req.query.name to ensure it is a string.
  2. If req.query.name is not a string, return a 400 Bad Request response with an appropriate error message.

References

querystring
CWE-843

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants